nefarius / HidHide

Gaming Input Peripherals Device Firewall for Windows.
https://docs.nefarius.at/projects/HidHide/
MIT License
939 stars 80 forks source link

Updater keeps poping up while newest Version is already installed #137

Closed Eden333 closed 9 months ago

Eden333 commented 9 months ago

Bug description

Updater keeps saying, that there is an Update, while the same Version is already installed. Happend already 3x times.

Steps to reproduce

Screenshots

image image

Machine info

CPU-Architecture: x64 Windows version: Windows 10 22H2 Software/driver version(s): 1.4.202

thexile commented 9 months ago

I suspect it is due to HidHide.sys still being 1.4.181.

image

nefarius commented 9 months ago

Nope, the updater is supposed to check against the Version value in HKEY_LOCAL_MACHINE\SOFTWARE\Nefarius Software Solutions e.U.\HidHide

Not every release contains a new driver, it is a waste of time to re-sign all the driver binaries if they have not changed.

Eden333 commented 9 months ago

here is my registry entry, its also showing the newest release image

nefarius commented 9 months ago

Looks correct, hm, oh well. I am done diagnosing weird and unexplainable nonsense of Advanced Installer components. I am almost done with my updater replacement, needs a couple more days, then I can give you a new release. In the meantime you can get rid of the popup by disabling the HidHide_Updater scheduled task:

image

mbc07 commented 9 months ago

I'm having the same issue. Just did a full uninstall and then reinstalled the same version it keeps asking me to update to, and yep, the updater still appears saying a new update is available...

nefarius commented 9 months ago

Welp, see my last post.

nefarius commented 9 months ago

@Eden333 can you please try this one http://sharex.nefarius.at/u/HidHide_1.5.212_x64.exe and give feedback.

QwerkyPengwen commented 9 months ago

@Eden333 can you please try this one http://sharex.nefarius.at/u/HidHide_1.5.212_x64.exe and give feedback.

have done testing with this installed and it indeed doesn't pop up saying it needs to update anymore.

thexile commented 9 months ago

Looking great! image

nefarius commented 9 months ago

Excellent, we're getting somewhere, first step to replace AI is a success then, I'll prepare an official release soon.

nefarius commented 9 months ago

@QwerkyPengwen @thexile what happens if you modify the Version value in HKEY_LOCAL_MACHINE\SOFTWARE\Nefarius Software Solutions e.U.\HidHide to something lower, like the previous release and then run the updater executable (found in C:\Program Files\Nefarius Software Solutions\HidHide\x64)?

ionzxp commented 9 months ago

I just did my research about this. for some reason, the current updater try to read version from HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Nefarius Software Solutions e.U.\HidHide which doesn't exist. image

copy values from HKEY_LOCAL_MACHINE\SOFTWARE\Nefarius Software Solutions e.U.\HidHide to the key above fixed the issue.

nefarius commented 9 months ago

I just did my research about this. for some reason, the current updater try to read version from HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Nefarius Software Solutions e.U.\HidHide which doesn't exist. image

copy values from HKEY_LOCAL_MACHINE\SOFTWARE\Nefarius Software Solutions e.U.\HidHide to the key above fixed the issue.

Sounds like follows: the AI updater binary is a 32-Bit executable while HH setup and components are 64-Bit, which will end up in the normal Software key in the Registry. The updater then looks in the 32-Bit (WOW6432Node) on the system, can't find the entry and falls back to reporting an outstanding update.

Nonetheless, it will get replaced, and the problem will be no more 😎 My own updater supports 32-Bit, 64-Bit and ARM64, no problem. Silly issue to have in 2024.

nefarius commented 9 months ago

New version is out! No risk no fun, publishing it via old updater mechanism, so long, ya bastard! 🖖