Fix bug, if the plugin fails, the `VIGEM_TARGETS_MAX` device will be created.

MiroKaku commented 4 years ago

Hi,

Describe the bug Starting from the fifth ‘plugin’, countless devices will be created. (VIGEM_TARGETS_MAX 0xFFFF)

To Reproduce Run this:

int main()
{
    static const auto target_number = 5;

    const auto client = vigem_alloc();
    auto ret = vigem_connect(client);
    if (!VIGEM_SUCCESS(ret))
    {
        std::cerr << "vigem_connect() failed! ret: " << std::hex << ret << std::endl;
    }

    PVIGEM_TARGET targets[target_number] = { nullptr };

    for (auto i = 0u; i < target_number; ++i)
    {
        targets[i] = vigem_target_x360_alloc();

        ret = vigem_target_add(client, targets[i]);

        std::cerr << "vigem_target_add(" << std::dec << i << ") ret: " << std::hex << ret << std::endl;
    }

    // pause
    (void)getchar();

    for (auto i = 0u; i < target_number; ++i)
    {
        vigem_target_remove(client, targets[i]);
        vigem_target_free(targets[i]);
    }

    vigem_free(client);

    return 0;
}

Expected behavior Create 4 or 5 devices, But created countless. (VIGEM_TARGETS_MAX 0xFFFF)

Screenshots