nefarius / vicius

Nefarius' nŏvīcĭus universal software updater agent for Windows.
https://docs.nefarius.at/projects/Vicius
BSD 3-Clause "New" or "Revised" License
38 stars 3 forks source link

Test and improve Markdown rendering #10

Closed nefarius closed 5 months ago

nefarius commented 7 months ago
nefarius commented 5 months ago

Working on embedded images support 👀

image

nefarius commented 5 months ago

Embedded images from remote resources now get downloaded and displayed correctly:

image

nefarius commented 5 months ago

Hyperlink color contrast fixed:

image

nefarius commented 5 months ago

Tested setting the flag MD_FLAG_PERMISSIVEURLAUTOLINKS to see if that would support GitHubs auto-generated plain changelog URLs but it doesn't a 100%:

image

I'll just ignore this; if folks need proper links, use proper Markdown in the summary 😎

nefarius commented 5 months ago

Found the best compromise:

image

Surround the URL like so:

**Full Changelog**: <https://github.com/nefarius/HidHide/compare/v1.4.192.0...v1.4.202.0>

And it gets rendered properly without any additional flags 🥳

nefarius commented 5 months ago

Debugging the clickable image URLs, when an "IMG" is rendered, it checks for mouse-over and release to trigger the link navigation, in the function imgui_md::SPAN_IMG it first sets the member m_href which parses the fragment http://sharex.nefarius.at/u/donation-button.gif)](https://docs.nefarius.at/Donations/) into:

  Name Value Type
m_href "http://sharex.nefarius.at/u/donation-button.gif" std::string

So instead of opening the underlying link, the URL to the image displayed is used in the open_url overload.

IDK if this case has not been tested properly or if this is considered expected behaviour; for me it certainly isn't 😛 Let's try to fix this.

nefarius commented 5 months ago

Everything I found is fixed 😄