Closed nefarius closed 5 months ago
Working on embedded images support 👀
Embedded images from remote resources now get downloaded and displayed correctly:
Hyperlink color contrast fixed:
Tested setting the flag MD_FLAG_PERMISSIVEURLAUTOLINKS
to see if that would support GitHubs auto-generated plain changelog URLs but it doesn't a 100%:
I'll just ignore this; if folks need proper links, use proper Markdown in the summary 😎
Found the best compromise:
Surround the URL like so:
**Full Changelog**: <https://github.com/nefarius/HidHide/compare/v1.4.192.0...v1.4.202.0>
And it gets rendered properly without any additional flags 🥳
Debugging the clickable image URLs, when an "IMG" is rendered, it checks for mouse-over and release to trigger the link navigation, in the function imgui_md::SPAN_IMG
it first sets the member m_href
which parses the fragment http://sharex.nefarius.at/u/donation-button.gif)](https://docs.nefarius.at/Donations/)
into:
Name | Value | Type | |
---|---|---|---|
▶ | m_href | "http://sharex.nefarius.at/u/donation-button.gif" | std::string |
So instead of opening the underlying link, the URL to the image displayed is used in the open_url
overload.
IDK if this case has not been tested properly or if this is considered expected behaviour; for me it certainly isn't 😛 Let's try to fix this.
Everything I found is fixed 😄