search

nefelim4ag / League-Of-Legends

Linux: League Of Legends www.leagueoflegends.com install/run wrapper
GNU General Public License v3.0
91 stars 10 forks source link

Shellcheck conformity #3

Closed ismaelgv closed 8 years ago

ismaelgv commented 8 years ago

You should check the bash scripts with Shellcheck. The package is in the community repo. It shows some errors and warnings in your scripts.

Nice idea, btw. :+1:

nefelim4ag commented 8 years ago

@ChuckDaniels87, thanks, i already used it for long time. This tool are too aggressive sometimes. ;)

ismaelgv commented 8 years ago

I agree it is a bit aggressive. Nevertheless I think it is a good idea at least to double quote some lines where appears $PREFIX and $LOL_INSTALL_PATH. Spaces there can break things.

nefelim4ag commented 8 years ago

@ChuckDaniels87, did i miss something https://github.com/Nefelim4ag/League-Of-Legends/commit/0d031c369042fc1bf98fa4d4a3eb3d9a009b1e70 ?

ismaelgv commented 8 years ago

In that file is fine now but some warning in the install.sh script are still present.

nefelim4ag commented 8 years ago

Oh, thanks, i fixed all shell scripts