neffo / bing-wallpaper-gnome-extension

GNOME shell extension that syncs your desktop & lock screen wallpaper to Microsoft Bing's Image of the Day.
https://extensions.gnome.org/extension/1262/bing-wallpaper-changer/
GNU General Public License v3.0
299 stars 56 forks source link

Version 39 not installing on Fedora 35 #155

Closed Sensei1304 closed 2 years ago

Sensei1304 commented 2 years ago

зображення

neffo commented 2 years ago

I can't reproduce, do you have any error description?

Screenshot from 2022-03-21 09-26-49

Update: likely this would be fixed by logging out and in again (or restarting)

Sensei1304 commented 2 years ago

Restart indeed fixed it, thanks

neffo commented 2 years ago

Thanks for report and confirmation of fix.

GNOME should auto update extensions (on restart), but forcing an update can sometimes break things (if that's what happened).

nathanael-naeri commented 2 years ago

I came here to report the same thing (albeit on Ubuntu 20.04 w/ GNOME 3.36.8). After a manual update, the GNOME Extensions website displays ERROR in red like in the OP's picture, and the extension's indicator disappears from the top bar, all of which is fairly alarming if you don't know it comes back after a restart.

The error message in /var/sys/syslog if logging is enabled is perfectly clear, but it isn't surfaced in the GNOME Extensions website or in the extension itself:

Mar 24 22:16:37 hostname gnome-shell[1660]: JS ERROR: Extension [BingWallpaper@ineffable-gmail.com](mailto:BingWallpaper@ineffable-gmail.com): Error: A different version was loaded previously. You need to log out for changes to take effect.#012loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:343:52#012callback@resource:///org/gnome/shell/ui/extensionDownloader.js:234:39#012gotExtensionZipFile/<@resource:///org/gnome/shell/ui/extensionDownloader.js:115:13

Can this behavior perhaps be documented in the README.md file? Or maybe in the About tab of the extension's settings, if it's more appropriate there? That might help new users who don't know about this GNOME quirk.

Also:

GNOME should auto update extensions (on restart)

Never happens in my case

but forcing an update can sometimes break things

Always happens in my case

neffo commented 2 years ago

Yeah, sorry the auto update functionality is in newer versions of GNOME (good to know people are still using 3.36 btw).

I'm not sure the best way to handle updating then, perhaps restart the shell through alt-f2, 'r' combo. We do have a mention in the description for the extension on EGO, but maybe not clear enough.

Screenshot_20220325-084257.png

nathanael-naeri commented 2 years ago

Thank you for pointing that out, and for the super-fast reply. I probably read that sentence when I installed your extension, and tried to make a mental note of it, but I had very clearly forgotten about it when I updated the extension for the first time.

Maybe you could move that sentence to the first paragraph of the text, so that it appears on https://extensions.gnome.org/local, which is where the Upgrade button is located which leads to the red ERROR message? That would probably make it more visible how to fix the error.

Screenshot from 2022-03-22 09-58-09

Yes, still using GNOME 3.36. As Ubuntu 20.04 is an LTS, it is here to stay I'm afraid.

neffo commented 2 years ago

Great point on moving the comment. Will do.

Happy to support 3.36, I just don't have visibility of how many people are using it. Given it's the current LTS I aim to keep it supported, though so don't worry about that.