neffo / bing-wallpaper-gnome-extension

GNOME shell extension that syncs your desktop & lock screen wallpaper to Microsoft Bing's Image of the Day.
https://extensions.gnome.org/extension/1262/bing-wallpaper-changer/
GNU General Public License v3.0
299 stars 56 forks source link

Stretched thumbnail in extensions menu #167

Closed Etamuk closed 2 years ago

Etamuk commented 2 years ago

Hello,

I noticed that some pictures are streched in the extensions menu (see screenshot please). It's not a really big problem, just cosmetics.

It would be nice, all pictures would keep their proportion.

Bildschirmfoto von 2022-04-15 12-04-47-50P Best wishes

neffo commented 2 years ago

Not really sure how this is happening, did one of the descriptions or copyrights have a very long German word in it? (To be clear, I mean a compound word that wouldn't be word-wrapped.)

Etamuk commented 2 years ago

I don´t think so. This happens with many pictures. This is only one example. The Bing-Wallpaper from today is also affected. And it's description is very short. A line wrap would be possible at every word (maybe except "New Jersey"). Bildschirmfoto von 2022-04-17 10-45-37 geaendert

This picture has a very very short description and copyright info:

Bildschirmfoto von 2022-04-17 10-51-47 geaendert

neffo commented 2 years ago

Hmm, for some reason those thumbnail images are wayyyy too small to start with. They should be 480x270, not sure why those values are being ignored. Do you have another extension that is compressing task bar?

image

Etamuk commented 2 years ago

Do you have another extension that is compressing task bar?

No, I only have a few extensions. The only one regarding the panel is Dash to panel. To test I disabled all the extension, but Bing-wallpaper. The behavior is the same.

Maybe it's because I am using an HiDPI-Screen (3840 x 2160 (16:9), scaled to 200%)?

neffo commented 2 years ago

Yeah that must be it, hmm. Sorry I assumed it was 1080p from the size of your screenshots.

Etamuk commented 2 years ago

Yes, I understand. But I always reduce the size to 50% before uploading it. Otherwise because of it's original size it is shown as huge image here ;-)

neffo commented 2 years ago

Haha yeah :) So this issue should be something we can deal with, I need to investigate the best/most reliable way to detect the scale factor that is affecting the indicator.

Etamuk commented 2 years ago

Thank you. Very nice.

neffo commented 2 years ago

This seems to have fixed it 82344e8, will bring in fixes in version 40 #160

image

Etamuk commented 2 years ago

That sounds good. I will have an eye on it :-)