neffo / bing-wallpaper-gnome-extension

GNOME shell extension that syncs your desktop & lock screen wallpaper to Microsoft Bing's Image of the Day.
https://extensions.gnome.org/extension/1262/bing-wallpaper-changer/
GNU General Public License v3.0
299 stars 56 forks source link

[BUG] Non-latin characters in path names are not handled correctly #173

Closed neffo closed 2 years ago

neffo commented 2 years ago

NOTE: GNOME will sometimes report errors associated extensions if you manually update them via the extensions website. These errors can be resolved by restarting GNOME shell (logging out and then back in again). If it's still creating errors, then please go ahead create an issue.

Describe the bug delacosta78's report for "Bing Wallpaper": Hello, I found a bug, when changing the folder where the images are saved and that folder has a tilde in the word (for example Imágenes) the extension is not detecting that properly and it's creating a separate folder in the home folder like this:

/home/myusername/Im%C3%A1genes/BingWallpaper

As you can see the extension is creating the "Im%C3%A1genes" folder instead of using the folder I want to use with the name "Imágenes" with a tilde in the letter a.

Screenshots If applicable, add screenshots to help explain your problem.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

neffo commented 2 years ago

should be fixed by #170

Issue was related to mistaken use of Filechooser get_uri() when get_path() should have been used.