[BUG] Not compatible with GNOME 43

scottbeamer commented 2 years ago

I'm running GNOME 43 beta. The final release is out on September 21. Could you update this extension to work with GNOME 43 at your earliest convenience? Thank you.

neffo commented 2 years ago

Similar to #180, this is breaking as GNOME 43 uses Soup 3 (for fetching www data) which is materially different from Soup 2. Thanks for reporting I am currently looking into it.

kflihan commented 2 years ago

Hi, I tried upgrading the soup code to soup-3 and its working for me now, and getting the new images from site. hope this help :)

changes to utils.js

removed this line: var BingImageURL = 'https://www.bing.com/HPImageArchive.aspx?format=js&idx=0&n=8&mbl=1&mkt=';

adding those lines: var BingImageURL = 'https://www.bing.com/HPImageArchive.aspx'; var BingParams = { format: 'js', idx: '0' , n: '8' , mbl: '1' , mkt: '' } ;

===============

changes to extension.js updated both _refresh & _downloadImage :


    _refresh() {
        if (this._updatePending)
            return;
        this._updatePending = true;
        this._restartTimeout();
        let market = this._settings.get_string('market');
        // create an http message
        let session = new Soup.Session();
        let url = BingImageURL ;
        log('fetching: ' + url);

        let params = Utils.BingParams;
        params['mkt'] = ( market != 'auto' ? market : '' ) ;
        log('-----------params: ' + JSON.stringify(params));

        let message = Soup.Message.new_from_encoded_form(
            'GET',
            url  ,   
            Soup.form_encode_hash(params)
            );

        session.send_and_read_async(
            message,
            GLib.PRIORITY_DEFAULT,
            null,
            (session, result) => {
                if (message.status_code === Soup.Status.OK) {
                    let bytes = session.send_and_read_finish(result);
                    console.log(`bytes: ${bytes}`);

                    let decoder = new TextDecoder('utf-8');
                    let data = decoder.decode(bytes.get_data());

                    console.log(`data: ${data}`);
                    log('Recieved ' + data.length + ' bytes');
                    this._parseData(data);
                    if (this.selected_image != 'random')
                         this._selectImage();
                } else if (message.status_code == 403) {
                    log('Access denied: ' + message.status_code);
                    this._updatePending = false;
                    this._restartTimeout(TIMEOUT_SECONDS_ON_HTTP_ERROR);
                } else {
                    log('Network error occured: ' + message.status_code);
                    this._updatePending = false;
                    this._restartTimeout(TIMEOUT_SECONDS_ON_HTTP_ERROR);
                }

            }
        );       

    }

_downloadImage(url, file) {
    let session = new Soup.Session();
    let message = Soup.Message.new(
        'GET',
        url     
        );  
    session.send_and_read_async(
        message,
        GLib.PRIORITY_DEFAULT,
        null,
        (session, result) =>  {
            // request completed
            this._updatePending = false;
            let bytes = session.send_and_read_finish(result);
            console.log(`bytes: ${bytes}`);
            let data = bytes.get_data();
           console.log(`status_code: ${message.status_code}`);
            if (message.status_code == 200) {
                file.replace_contents_bytes_async(
                    data,
                null,
                false,
                Gio.FileCreateFlags.REPLACE_DESTINATION,
                null,
                (file, res) => {
                        try {
                            file.replace_contents_finish(res);
                            this._setBackground();
                            log('Download successful');
                        } catch(e) {
                            log('Error writing file: ' + e);
                        }
                    }
                )  ;
            } else {
            log('Couldn\'t fetch image from ' + url);
            file.delete(null);
        }
         });
}

neffo commented 2 years ago

Thanks heaps @kflihan , very helpful. I've implemented some of the above code in #177 (extension version 42). It's not quite as clean as I'm still trying to retain support for GNOME Shell versions < 43. (I also cleaned up your post to help me read it :))

neffo commented 2 years ago

Ok, I have a working version in the test branch 'version 42' now. Very fiddly... the documentation for Soup 3 doesn't reflect what works in GJS. Should be possible to push this before GNOME 43 is released.

kflihan commented 2 years ago

thanks, I'm testing 'version 42' under Fedora 37 Beta (Wayland session), I had to add support to Gnome "43.rc" to metadata.json.