search

neffo / earth-view-wallpaper-gnome-extension

A beautiful satellite image from Google Earth as your GNOME desktop wallpaper.
https://extensions.gnome.org/extension/1295/google-earth-wallpaper/
GNU General Public License v3.0
67 stars 8 forks source link

SyntaxError: illegal character #2

Closed simonouel closed 7 years ago

simonouel commented 7 years ago

Hi there great extension by the way! Just to let you know that I installed it on centos 7.4, gnome 3.22 I run the this commit: aaed8e82d67a67071cea8c9a544de2afea69aafa

All is working fine except the "Settings" is not openning and I have the error show up:

SyntaxError: illegal character

Stack trace:
  Application<._getExtensionPrefsModule@resource:///org/gnome/shell/extensionPrefs/main.js:74
  wrapper@resource:///org/gnome/gjs/modules/lang.js:178
  Application<._selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:89
  wrapper@resource:///org/gnome/gjs/modules/lang.js:178
  Application<._onCommandLine@resource:///org/gnome/shell/extensionPrefs/main.js:239
  wrapper@resource:///org/gnome/gjs/modules/lang.js:178
  main@resource:///org/gnome/shell/extensionPrefs/main.js:377
  @<main>:1

I didn't have the issue with the version 1

neffo commented 7 years ago

Hmm, I am not seeing that with Ubuntu 17.04 or Fedora 26. It's probably an issue with a strange apostrophe sneaking in to the code.

Can you share with me the output of this command? gjs $HOME/.local/share/gnome-shell/extensions/GoogleEarthWallpaper@neffo.github.com/prefs.js

It may be related to the multi-line literal code starting at line 138 (the back ticks). That is new, and I was probably being trying to be too clever.

neffo commented 7 years ago

Oh, it is the back ticks causing the problem.

String Template Literals were only added in Gnome 3.24. Whoops!