Version 13 - Githubissues

neffo / earth-view-wallpaper-gnome-extension

A beautiful satellite image from Google Earth as your GNOME desktop wallpaper.

https://extensions.gnome.org/extension/1295/google-earth-wallpaper/

GNU General Public License v3.0

67 stars 8 forks source link

Version 13 #26

Closed neffo closed 3 years ago

neffo commented 3 years ago

Fixes required for GNOME 41 support and extension approval reference:

[x] update metadata.json, fix point release support #25
[x] replace all references to Lang.bind() (13)
[x] update build script to remove unnecessary files (.po, .h, etc)
[x] move all code within class (nothing in init() or in global scope other than localisation)
[x] fix tray icon switching
[x] Test on GNOME 38
[x] Test on GNOME 40
[x] Test on GNOME 41

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging f5cef3bbea30e09a47b67c0e799c5b67ddb81648 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 526dd8ff2fb17d9eb63f3f8f3beb884b91873d28 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

motorto commented 3 years ago

Some questions

"replace all references to Lang.bind() (13)" fixes the issue #13 or is just the version ? Is this what you meant ?
I don't know how to work now with git since its your branch, I already added this branch to my fork, but I don't know how GitHub will react when I push a changed (maybe create a new pull request ???) , so I will probably create patches is that alright ? )

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 291353864a8145e0e0cbadc1337e2df15ccc1e1c into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

neffo commented 3 years ago

Yep, most of the deprecated library calls were Lang, but we also had Mainloop and a few others still in there. I think I've fixed most of them now.

I might be possible to create a fork from the 'version-13' branch, and then submit PRs to it. I created the 'version-13' branch then pulled your PR into the new branch, sorry if that confused things. That probably means your original fork can't be used anymore? I'm unsure.

motorto commented 3 years ago

No you didn't make it confuse, I just wasn't sure how GitHub was going to behave...

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 77068a7ffde28249e6405f17d86234676aa4bb74 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging f77dcf954e7431066b2b4550aaa4c42f2515d927 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

motorto commented 3 years ago

Well you got ahead of me and did everything, probably for the better since you know the source code better than I :)

Do you do any kind of testing or you just install the extension and set the wallpaper ?

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging e735dd47af5433a3101720b50316fbaed807c837 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 6ab6655ded3bc5fb8d0bef9b868418afcadd03d7 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

neffo commented 3 years ago

Do you do any kind of testing or you just install the extension and set the wallpaper ?

I run some linting checks, but nothing automated in the sense of unit tests, etc. I have some VMs that I can spin up for different GNOME versions.

Certainly happy if you want to do propose and implement changes, most of these fixes I've made were long standing issues I had been ignoring. :)

Once, I've done some testing this will probably get published to extensions.gnome.org.

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging fdeb31d52724b1175cbaf116326c08bd5c5002e8 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 85f28b574e5829a0fdec6f0576c8952d88f6f676 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 4905c37a33e5110da3632e2142764c938ddc6438 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 619e0d83da300c1c2980c7ff126f49574b6bebe1 into 37117e9221edfdddee2ecacbf8ea687f43753260 - view on LGTM.com

fixed alerts:

2 for Incomplete string escaping or encoding
1 for Unreachable statement
1 for Missing variable declaration