search

nefrob / vscode-just

VSCode syntax highlighting for just files
https://marketplace.visualstudio.com/items?itemName=nefrob.vscode-just-syntax
MIT License
68 stars 1 forks source link

GitHub Linguist? #15

Closed nk9 closed 2 months ago

nk9 commented 5 months ago

Would you be interested in getting the syntax into a state that was sufficiently improved that it could be nominated for inclusion in GitHub Linguist? The current syntax has issues, and the work here would be in the same format, and thus potentially useable by Linguist. (Unfortunately, Linguist doesn't support the newst Sublime syntax, nor TreeSitter.)

nefrob commented 5 months ago

@nk9 Ah hadn't heard of that before. If I have time to nail down the grammar accurately (currently just throwing things together pretty ad hoc) and gracefully handle the edge cases that require an LSP/parser to support that sounds like an option. Also open to contributions if you/anyone are/is particularly familiar with building syntax grammars.

tgross35 commented 5 months ago

I spent a lot of effort getting tree-sitter-just working well and pretty thoroughly tested, I don’t know how similar the patterns are but maybe it could serve as a reference: https://github.com/IndianBoy42/tree-sitter-just

nefrob commented 2 months ago

PR opened here: https://github.com/github-linguist/linguist/pull/6985.

nefrob commented 2 months ago

Now live: https://github.com/github-linguist/linguist/releases/tag/v8.0.0.