negativecode / vines

An XMPP chat server for Ruby.
http://www.getvines.org/
MIT License
471 stars 75 forks source link

Ruby 2.1.2 fixes #35

Closed monban closed 10 years ago

monban commented 10 years ago

Cleanup for Ruby 2.1.2. Everything seems to be working without errors or warnings EXCEPT #34, which is sporadic.

monban commented 10 years ago

Thanks for pointing out my over-complication of things. I went ahead and tested the pure OpenSSL::Digest.new("sha512") on Ruby 1.9.3 (as I should have in the first place...) and as you said, it works fine.

I would still like to avoid "pessemistic dependency" warnings when building the gem. As long as only the minor version changes there shouldn't be any breakage, in theory, only bugfixes right?

I haven't been developing under major external dependencies long enough to know how true or not that might be. I will just leave that one to your discretion, thanks.

dgraham commented 10 years ago

As long as only the minor version changes there shouldn't be any breakage, in theory, only bugfixes right?

If only ruby gems actually worked that way! I see what you mean now about the warnings:

$ bundle exec rake build
WARNING:  pessimistic dependency on bcrypt-ruby (~> 3.0.1) may be overly strict
  if bcrypt-ruby is semantically versioned, use:
    add_runtime_dependency 'bcrypt-ruby', '~> 3.0', '>= 3.0.1'
WARNING:  pessimistic dependency on em-hiredis (~> 0.1.1) may be overly strict
  if em-hiredis is semantically versioned, use:
    add_runtime_dependency 'em-hiredis', '~> 0.1', '>= 0.1.1'
WARNING:  pessimistic dependency on eventmachine (~> 1.0.3) may be overly strict
  if eventmachine is semantically versioned, use:
    add_runtime_dependency 'eventmachine', '~> 1.0', '>= 1.0.3'
WARNING:  pessimistic dependency on http_parser.rb (~> 0.5.3) may be overly strict
  if http_parser.rb is semantically versioned, use:
    add_runtime_dependency 'http_parser.rb', '~> 0.5', '>= 0.5.3'
WARNING:  pessimistic dependency on net-ldap (~> 0.3.1) may be overly strict
  if net-ldap is semantically versioned, use:
    add_runtime_dependency 'net-ldap', '~> 0.3', '>= 0.3.1'
WARNING:  pessimistic dependency on nokogiri (~> 1.5.10) may be overly strict
  if nokogiri is semantically versioned, use:
    add_runtime_dependency 'nokogiri', '~> 1.5', '>= 1.5.10'
WARNING:  pessimistic dependency on minitest (~> 5.0.5, development) may be overly strict
  if minitest is semantically versioned, use:
    add_development_dependency 'minitest', '~> 5.0', '>= 5.0.5'
WARNING:  pessimistic dependency on rake (~> 10.1.0, development) may be overly strict
  if rake is semantically versioned, use:
    add_development_dependency 'rake', '~> 10.1', '>= 10.1.0'
WARNING:  See http://guides.rubygems.org/specification-reference/ for help
  Successfully built RubyGem
  Name: vines
  Version: 0.4.8
  File: vines-0.4.8.gem

I'll take a look at using newer versions of them, particularly nokogiri, which broke in the initial 1.6.0 release. It's probably better now.