search

negativecode / vines

An XMPP chat server for Ruby.
http://www.getvines.org/
MIT License
470 stars 75 forks source link

introduces .gemspec and Gemfile for easier development setup #9

Closed benzimmer closed 12 years ago

benzimmer commented 12 years ago

bundle install installs all gems needed for working on vines.

I needed to change the required eventmachine version to '1.0.0.beta.4' because the used em-http-request version 1.0.1 also depends on it.

would close issue #3

benlangfeld commented 12 years ago

+1

I would go further and add the bundler rake tasks.

dgraham commented 12 years ago

I'm hesitant to add this because it implies gem build is the right way to build and push the vines gem. It needs to be built by saying rake so that the generated web resources are included in the gem. I haven't seen a good way to handle files generated during the build with bundler.

benlangfeld commented 12 years ago

At the very least, the gemspec should be included in the repo rather than generated, with the Gemfile pointing to the gemspec (0fec25a). The rake tasks are less important IMO.

benlangfeld commented 12 years ago

Any chance of this being merged?

dgraham commented 12 years ago

Thanks, Ben!