search

negativetwelve / react-native-lookback

React Native module for Lookback.io
MIT License
13 stars 7 forks source link

[iOS] Adds getIsRecording method #23

Closed jasonmerino closed 7 years ago

jasonmerino commented 7 years ago

Needed to get current recording status of Lookback.io SDK for the case where the user does not accept the terms and conditions and the recording doesn't actually start.

jasonmerino commented 7 years ago

Okay, I believe I've fixed up the formatting to match.

I don't think there needs to be any bump of the Lookback SDK. Our podfile says we've got "LookbackSafe", "~> 1.4.1" installed. I'm not sure if the isRecording getter is a new method to the Lookback SDK though.

As far as NPM goes, it's additive and I didn't change any of the existing methods, so it should be good to go out as a minor release there.

negativetwelve commented 7 years ago

looks good! Release on npm as 1.3.1