search

negesti / gnome-shell-extensions-negesti

An gnome-shell extension that makes window movement a lot easier.
GNU General Public License v3.0
287 stars 46 forks source link

moving focus stopped working with gnome shell version 3.34 #171

Closed tocomo closed 3 years ago

tocomo commented 4 years ago

gnome-shell Version: 3.34.1-1ubuntu1 throws errors:

Nov 18 11:37:59 ... gnome-shell[9258]: JS ERROR: TypeError: this._construct is not a function newClass@resource:///org/gnome/gjs/modules/_legacy.js:114:32 _flashWindow@/home/tobias/.local/share/gnome-shell/extensions/putWindow@clemens.lab21.org/moveFocus.js:156:21 _activateWindow@/home/tobias/.local/share/gnome-shell/extensions/putWindow@clemens.lab21.org/moveFocus.js:166:7 _focusNearestCandidate@/home/tobias/.local/share/gnome-shell/extensions/putWindow@clemens.lab21.org/moveFocus.js:498:5 _moveFocus@/home/tobias/.local/share/gnome-shell/extensions/putWindow@clemens.lab21.org/moveFocus.js:473:5 _enable/<@/home/tobias/.local/share/gnome-shell/extensions/putWindow@clemens.lab21.org/moveFocus.js:176:36

negesti commented 4 years ago

I'm not using 3.34 yet, maybe @73 can check this?

73 commented 4 years ago

Will do on Monday.

On Sat, Dec 7, 2019, 09:49 negesti notifications@github.com wrote:

I'm not using 3.34 yet, maybe @73 https://github.com/73 can check this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/negesti/gnome-shell-extensions-negesti/issues/171?email_source=notifications&email_token=AAEBHQXGHC2RRY754XLXZ6TQXNPRZA5CNFSM4JOROHN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGBVWA#issuecomment-562830040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEBHQUI6QBXHGOBUS3CQG3QXNPRZANCNFSM4JOROHNQ .

73 commented 4 years ago

Okay, the code related to flashing the window on focus change is broken. I vote for removing the code. Moving focus works, but animation does not.

negesti commented 4 years ago

Sounds fine for me