search

negesti / gnome-shell-extensions-negesti

An gnome-shell extension that makes window movement a lot easier.
GNU General Public License v3.0
287 stars 46 forks source link

Gnome 3.14 porting: deleted/deprecated function #68

Closed ilSant0 closed 9 years ago

ilSant0 commented 10 years ago

Platform: Gnome 3.14@Arch I see some deprecated function in project code like: -get_outer_rect (existing but deprecated) -get_rect (not found in dev. docs, i think it was removed)

And some other trouble around "Mainloop is not defined" function . Why i say so?

Because I've some problem with Put Windows on my systems (a part the tons of error messages in my system log), especially during resizing of windows: it seems that the extension can not get the correct size of screen and it move windows over the edges of the screen. Maybe, what I wrote above is the cause of my problem, or maybe not, I don't know, I'm not a programmer but i hope it will help the development of this great (essential) extension.

negesti commented 10 years ago

thanks for investigating the problem.

the extension must calculate the window padding/margin before it can calculate the real target size and position. due to the api changes you described the calculation is wrong and windows are placed incorrect.

I will try to get a vm running 3.14 and debug this

ilSant0 commented 10 years ago

I tried a little bit and it's really better now, resizing/moving windows works well now (a part a minor issue on padding between window with full width and bottom of screen). Still remain a issue with secondary monitor: sometimes, the move o resize of the windows on secondary monitor, cause them to pass wrongly to the primary monitor.

I hope it help you.

negesti commented 10 years ago

hard to test, i will try to confince my vm that i have two screens..

negesti commented 9 years ago

upgraded to fedora 21, improvement is on the way

73 commented 9 years ago

Should we create a branch from current "Develop" for Gnome-Shell 3.12 and begin with porting work to 3.14?

negesti commented 9 years ago

Runs with my 3.14 Installation including move focus. Looks like i forgot to push... Sry

73 commented 9 years ago

I refactored some of the code: Meta.Window.move() deprecated but Meta.Window.move_frame() dates back to 3.8 so I removed move(). And made some other changes, see: 04fe49be92980faf189f6fad7e2f6e302fbd9f79 Since I only have a Fedora 21 now I tested only on Shell 3.14.2!

negesti commented 9 years ago

thanks, added the changes to the current version

73 commented 9 years ago

Then I think we can close this issue.