negesti / gnome-shell-extensions-negesti

An gnome-shell extension that makes window movement a lot easier.
GNU General Public License v3.0
287 stars 46 forks source link

Hotkey is grabbed even when disabled #93

Closed eddy-geek closed 8 years ago

eddy-geek commented 8 years ago

This occurs at least for "Move to right screen" hotkey: even if the "Enabled" box is unchecked in "Keyboard Shortcuts" preferences panel, the default hotkey (Shift+Super+Right) is still grabbed, disabling gnome's "Move to next screen" hotkey if oconfigured to the same combination.

Workaround is to change to anything else e.g. Shift+Alt+Super+Right

negesti commented 8 years ago

I'm unabel to reproduce this. Are your running an up to date version of gnome-shell and the extension? You could try to restart the shell (alt+f2 - r) and check if the keybinding is removed/not added after a restart.

eddy-geek commented 8 years ago

I can confirm that even after multiple restarts issue persists. I can reproduce by changing the hotkey back to Shift+Super+Right even without toggling the "enabled" checkbox

Also it seems that there is no way set an emtpy hotkey (unlike gnome-shell hotkey editor where pressing Backspace key does the trick.

Fedora 23, gnome-shell 3.18.4, not sure for Put windows but it is up-to-date according to https://extensions.gnome.org/local/

negesti commented 8 years ago

i was not able to add validation to the UI that allowed empty keys and worked correct. That's why i added the enable/disable checkboxes to all settings. Just setting it to an empty hotkey would be easier and more gnome like. Unfortunately i don't have enough time atm.

The settings are stored in dconf /org/gnome/shell/extensions/org-lab21-putwindow/. Can you check please, if the keybinding for "Move to right screen" is disabled in dconf settings properly. e.g. run

dconf read /org/gnome/shell/extensions/org-lab21-putwindow/put-to-right-screen-enabled

or open dconf-editor and navigate to the folder. The settings is immediately updated after changing it in PutWindow config window.

negesti commented 8 years ago

@eddy-geek i need the stored settings to fix this

negesti commented 8 years ago

have you tried this with the current version? the keybinding can be disabled using the backspace now. Please reopen the issue if it still exists