add some enhancement in workflow and speed up it abit

negipo / rails-finder

Atom package to enable fuzzy find with rails project

MIT License

6 stars 2 forks source link

add some enhancement in workflow and speed up it abit #3

Closed shemerey closed 8 years ago

shemerey commented 8 years ago

Here is some enhancements, what I've found to be useful for me. May be you will be interesting in adoption.

[x] use atom.project to get railsRootPath instead of text-editor it will allow you to open finder right after you open new rails project
[x] don't close finder when you search by Model and hit search by Controller
[x] ignore binary like files, images, fonts etc.

negipo commented 8 years ago

Hi, Sorry for late. I will check this soon.

negipo commented 8 years ago

Well, sorry but this pr is not suit for plugin purpose. This plugin must cover specific project (mine :)) which contains multiple rails apps. It have to open files within current rails app which the opening file placed. So, as I wrote in README, you cannot open select list view while you are not opening a file in rails project, because this package search rails project dynamically for the current active file path is the intentional limitation.

Anyway your code is very nice. Thanks. I will import ignore binary like files, images, fonts etc. as another pr soon.