negomi / react-burger-menu

:hamburger: An off-canvas sidebar component with a collection of effects and styles using CSS transitions and SVG path animations
http://negomi.github.io/react-burger-menu/
MIT License
5.04k stars 582 forks source link

aria-hidden and visibility:hidden on closed menu #404

Closed fabb closed 3 years ago

fabb commented 3 years ago

Currently on iOS with VoiceOver, the hidden elements of the menu are being highlighted when stepping through all elements when swiping with two fingers. To improve this, the menu should set aria-hidden="true" in the DOM when being hidden.

Related: even when the menu is hidden, the menu content is tabbable. The cleanest solution to solve this would be to set visibility:hidden on the menu when it is hidden (but not during hide animation, as it would blank out).

negomi commented 3 years ago

Fixed in 2.9.0