search

negomi / react-burger-menu

:hamburger: An off-canvas sidebar component with a collection of effects and styles using CSS transitions and SVG path animations
http://negomi.github.io/react-burger-menu/
MIT License
5.04k stars 582 forks source link

Dependency issue with React 17 #415

Closed azivkovi closed 3 years ago

azivkovi commented 3 years ago

Trying to install the package to React 17 project results with the following error message:

npm ERR! Could not resolve dependency: npm ERR! peer react@">=0.14.0 <17.0.0" from react-burger-menu@2.9.0

rafipiccolo commented 3 years ago

I guess you only need to change thoses lines in this file : https://github.com/negomi/react-burger-menu/blob/main/package.json

"peerDependencies": { "react": ">=0.14.0 <17.0.0", "react-dom": ">=0.14.0 <17.0.0" },

to

"peerDependencies": { "react": ">=0.14.0 <18.0.0", "react-dom": ">=0.14.0 <18.0.0" },

Could you provide a pull request ? then the author will merge it ?

negomi commented 3 years ago

This would need https://github.com/negomi/react-burger-menu/issues/353 to be completed too, as well as just changing the peer dependency versions.

rafipiccolo commented 3 years ago

pull request done. can some please merge it and publish the new package ? I think that #353 is not required. (although it may be good)

negomi commented 3 years ago

Fixed in 3.0.0