Closed kimyu92 closed 1 year ago
Please kindly review it and let me know if you need any additional information.
cc @negomi
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Related Issue or PR:
https://github.com/negomi/react-burger-menu/issues/413 https://github.com/negomi/react-burger-menu/pull/426
Issue:
When working with other libraries where menu is opened, keyboard navigation or focus is affected due to specificity of
tabindex
for.bm-item
I can see why we need
tabIndex=-1
when something is closed. However, it may not be necessary to specifytabIndex=0
when menu is opened.According to https://html.spec.whatwg.org/multipage/interaction.html#attr-tabindex, or related discussions, if an element is meant to be accessible, it should follow semantic html like using
button
,heading
and if it's custom implementation, probably attributerole
oraria-*
should be used. Otherwise, we should let browser to do its own thing.