negomi / react-burger-menu

:hamburger: An off-canvas sidebar component with a collection of effects and styles using CSS transitions and SVG path animations
http://negomi.github.io/react-burger-menu/
MIT License
5.05k stars 586 forks source link

Unknown prop `_radiumDidResolveStyles` on <div> #75

Closed hansbonini closed 8 years ago

hansbonini commented 8 years ago

Im getting this error in console and menu don`t show up. How to solve?

Warning: Unknown prop _radiumDidResolveStyles on

tag. Remove this prop from the element. For details,

negomi commented 8 years ago

This is caused by upgrading to React 15.2, which introduces warnings about unknown props.

The actual error is being thrown by Radium, which this package depends on. Looks like they already have an issue open about this: https://github.com/FormidableLabs/radium/issues/759

So you can keep an eye on that for updates, or downgrade to React 15.1 to avoid the error for now if it's an issue.

sunkaflek commented 8 years ago

should be fixed in radium v0.18.0, update package pls?

negomi commented 8 years ago

This is now fixed. The current semver range will allow for minor version updates of dependencies, so no need for an update in this package. Thanks!

sunkaflek commented 8 years ago

Ah ok, thank you Imogen!

Vincz commented 8 years ago

Hi :)

Looks like the warning have been fixed in Radium v0.18 (see https://github.com/FormidableLabs/radium/commit/bf2ce19d4c5ccad0a8487c535338877b241e0104). When installing react-burger-menu, it keeps installing radium v0.17.2.

SpainTrain commented 8 years ago

"radium": "^0.17.0", that semver range does not pick up 0.18.X

^0.2.3 := >=0.2.3 <0.3.0

https://github.com/npm/node-semver#caret-ranges-123-025-004

Fixed here: https://github.com/negomi/react-burger-menu/pull/82

check out https://www.npmjs.com/package/npm-check which is an awesome tool to help with updating deps (no need to memorize node-semver rules)

negomi commented 8 years ago

This is fixed in v1.9.9.

Thanks for the link to the more thorough explanation @SpainTrain. I did not know about the left-most non-zero digit rule when using caret ranges. I'd read https://docs.npmjs.com/getting-started/semantic-versioning#semver-for-publishers, and other things which unfortunately all failed to specifically mention this detail.

Yay for learning new things at least 😄