negue / meme-box

Manage and trigger media in OBS as a browser source
meme-box.vercel.app
GNU Affero General Public License v3.0
112 stars 16 forks source link

Issue in: Action Edit Dialog - Recipe #473

Closed matthewbrandt closed 2 years ago

matthewbrandt commented 2 years ago

Whenever the !pokemon command is triggered in Twitch chat, the media plays but then Memebox doesn't play any media afterwards (no matter if triggered by Twitch chat or directly via Triggers)

The Pokemon is configured as a recipe to trigger one of 9 random media sources. It was created prior to v2022.1-beta-1 (which I am currently running).

Logs are attached. memebox_tsed.2022-07-22.log

negue commented 2 years ago

Hey,

could it be that you are using queue's which then maybe lock up one of random triggers? (usually these would resolve them selves but I don't know yet)

I see that I need to improve the logs a bit - because there a good amount of preview images not showing in the overview and thats why creaing some spam in the logs (that I'll try to fix / extend these logs)

since some versions new videos will get the first a preview image - but all previous ones need to set that manually - please press image that so that the previews will in the overview

matthewbrandt commented 2 years ago

I recreated a new Recipe with random videos (same video actions) and it still has the same issue. I do think it is queue related as the actions are all in the "meme" queue. Updating the screenshot position doesn't change anything either.

negue commented 2 years ago

Does the Recipe has a queue or even the same queue as the actions you added inside?

Could you try it without queues as well ?

matthewbrandt commented 2 years ago

I tested various things:

So for now I removed the queue entirely from the Recipe and all the actions (that took a long time to edit each one). I think the queue system needs to be looked at again with how it interacts with Recipes that use random logic.

matthewbrandt commented 2 years ago

Here are the configs for last night when the queue was still active and the config now with all the queues removed. (Tokens have been removed from the config) They're zipped as Github doesn't support JSON or BACKUP files. configs.zip

negue commented 2 years ago

The new Pre-Release 2022.1-rc1 will have that fixed - it was an issue not of the queue but rather checking if one of the Actions are "done"