negue / meme-box

Manage and trigger media in OBS as a browser source
meme-box.vercel.app
GNU Affero General Public License v3.0
111 stars 16 forks source link

Use `pkg` for standalone binary bundling #511

Closed dnaka91 closed 1 year ago

dnaka91 commented 1 year ago

My attempt to get pkg working as an alternative to nexe, so we're not bound to Node 12.16.2 anymore. So far seems to work, as far as I could tell, but I didn't test much of any specific features.

Probably there is some duplicate in the package.json by double-bundling release/*.js as scripts AND assets. Thought to look into that a bit further, but maybe best to verify that everything works and then we can tweak the settings.

You mentioned some special behavior with nexe and vm2 for the scripting feature. Maybe you can give that a quick try with this PR or tell me how to test that myself?

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
meme-box ✅ Ready (Inspect) Visit Preview Oct 2, 2022 at 3:17PM (UTC)
negue commented 1 year ago

Oh this is awesome!!! I don't know exactly what it was that I couldn't use pkg back then but hopefully it works now :)

During each build_executables it triggers

  • run: release/out/memebox --cli-test-mode=true --config=./release/config

Which internally starts memebox itself a) can it startup without any issues and b) starts a script to test the vm2 package

soo once the CI goes past the nexe (now pkg) command we'll know if all works out

negue commented 1 year ago

Tested it locally awesome!! - it works

Thank you for that - that was a long time issue with all the node12 build issues because of nexe - merging that in

Would you like to be added to the contributors list?