negue / meme-box

Manage and trigger media in OBS as a browser source
meme-box.vercel.app
GNU Affero General Public License v3.0
111 stars 16 forks source link

Improve Cypress execution time in CI #512

Closed dnaka91 closed 1 year ago

dnaka91 commented 1 year ago

While working on the other PRs, I noticed that the Cypress GitHub Action does a complete clean install by running npm ci. According to the docs, that means all already installed dependencies will be wiped and installed again.

In our CI setup, we already install everything beforehand, as we run some other tests first. It's likely we don't need this step at all and can improve CI performance quite a bit, by avoiding the extra setup work from Cypress.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
meme-box ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 1:52AM (UTC)
negue commented 1 year ago

@all-contributors please add @dnaka91 for code, doc, platform

allcontributors[bot] commented 1 year ago

@negue

I've put up a pull request to add @dnaka91! :tada:

negue commented 1 year ago

Now the PR CI is quite fast - with your change and mine yesterday (it skips the npm install completely if the package.json cache was hit) it'll improve the time by 5-6 Min :)