nehalist / gatsby-theme-nehalem

A Gatsby blog theme.
https://nehalem.netlify.com/
168 stars 60 forks source link

Site Metadata options not applying #28

Open imnotteixeira opened 3 years ago

imnotteixeira commented 3 years ago

Hey there! Just stumbled upon this theme and I am really liking its features.

I was just looking at how I could change the topics that show up on the homepage like bloggers, geeks, nerds,people,everyone` and I noticed you mention on the docs I can pass siteMetadata on the gatsby-config. However, it's not taking effect.

I inspected the code and on the default gastby-config (on the theme), you don't take into account the themeOptions.siteMetadata, I added ...themeOptions.siteMetadata to the end of the default options directly on the theme's gatsby-config on node_modules and it worked, since it overrides any provided fields of siteMetadata available on the user's config, so I believe it should be added.

I'd like to know if I did something wrong, and it should work already, or what you think about the proposal :)