neharob / prettyfaces

Automatically exported from code.google.com/p/prettyfaces
0 stars 0 forks source link

Remove apache commons dependencies #96

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Do this using maven shade to start, then remove entirely if possible.

Original issue reported on code.google.com by lincolnb...@gmail.com on 25 Mar 2011 at 2:41

GoogleCodeExporter commented 9 years ago

Original comment by lincolnb...@gmail.com on 25 Mar 2011 at 2:41

GoogleCodeExporter commented 9 years ago
Please verify!

Original comment by lincolnb...@gmail.com on 25 Mar 2011 at 3:39

GoogleCodeExporter commented 9 years ago
Great! This is a first step for getting rid of the commons stuff! :-)

I'll try to find some time on the weekend to test it with some of my apps. I 
think commons-logging and commons-beanutils are doing much reflection so we 
should test this carefully.

Original comment by chkalt on 25 Mar 2011 at 4:04

GoogleCodeExporter commented 9 years ago
Seems like the commons-* dependencies are still packaged with my WAR because 
their are 'compile' scoped.

Original comment by chkalt on 27 Mar 2011 at 5:37

GoogleCodeExporter commented 9 years ago
Try again now. This should be resolved!

Original comment by lincolnb...@gmail.com on 1 Apr 2011 at 2:49

GoogleCodeExporter commented 9 years ago
Great! Now it works! I think the problem occurred because the digester 
dependency was declared in the master pom.xml (which is not shaded into the 
artifacts) and not in the core pom.xml, correct?

Original comment by chkalt on 2 Apr 2011 at 9:52

GoogleCodeExporter commented 9 years ago

Original comment by lincolnb...@gmail.com on 20 Apr 2011 at 4:57