neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 352 forks source link

Improve readability of the results graph tooltip #233

Closed ivan-aksamentov closed 4 years ago

ivan-aksamentov commented 4 years ago

🙋 Feature Request

Presence

Currently lines in the tooltip appear and disappear depending on a value of a particular point on x axis. Making focusing on a particular line difficult. In particular, a line "ICU overflow" disappears when zero. Same with all "Confirmed" lines.

Color

Additionally, some of the entries are colored such that they don't have a sufficient contrast on the white background. This somehow happens with the most important entries, such as "Deaths" and "Confirmed *".

🔦 Context

Some work is done in https://github.com/neherlab/covid19_scenarios/pull/157 After it merged, we can take a look at further improvements.

😯 Describe the feature

💻 Examples

💁 Possible Solution

Related

kmid5280 commented 4 years ago

@ivan-aksamentov Regarding making the color scheme accessible, I found a way to make the lines dotted. We could potentially take similarly-colored lines and make them dotted or solid, or find other ways to differentiate them. Would that be a good start?

dotted lines

ivan-aksamentov commented 4 years ago

@kmid5280 Hm, I am not sure. Dotted lines change semantics, so that should be coordinated with our science team. I summon @rneher and @nnoll ! :sparkles:

kmid5280 commented 4 years ago

@ivan-aksamentov Any further thoughts on this idea so far?

gj262 commented 4 years ago

I will take a look at the first 4 tasks of this unless someone else is working on it? It should also help alleviate #234

ivan-aksamentov commented 4 years ago

Mostly resolved by #495