neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

fix: make sure ranges are validated in the form #643

Closed ivan-aksamentov closed 4 years ago

ivan-aksamentov commented 4 years ago

Related issues and PRs

Description

Ensures that form range spinboxes are properly validated, in particular that range begin is less or equal to range end.

Impacted Areas in the application

Testing

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/1o57os0h2 βœ… Preview: https://covid19-scenarios-git-fix-range-validation.covid19-scenarios.now.sh

codecov[bot] commented 4 years ago

Codecov Report

Merging #643 into master will decrease coverage by 0.10%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   21.66%   21.56%   -0.11%     
==========================================
  Files         112      112              
  Lines        2331     2342      +11     
  Branches      360      358       -2     
==========================================
  Hits          505      505              
- Misses       1826     1837      +11     
Impacted Files Coverage Ξ”
src/components/Form/FormRangeSpinBox.tsx 0.00% <0.00%> (ΓΈ)
src/components/Form/RangeSpinBox.tsx 0.00% <0.00%> (ΓΈ)
src/components/Form/SpinBox.tsx 0.00% <0.00%> (ΓΈ)
src/components/Main/Mitigation/MitigationTable.tsx 0.00% <0.00%> (ΓΈ)
src/components/Main/validation/schema.ts 0.00% <0.00%> (ΓΈ)
src/helpers/getFormikErrors.ts 0.00% <0.00%> (ΓΈ)
codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 544f88d1 and detected 0 issues on this pull request.

View more on Code Climate.