Closed abrie closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/e0g8b1i9g ✅ Preview: https://covid19-scenarios-git-fork-abrie-refactor-deterministiclineplot.covid19-scenarios.now.sh
Code Climate has analyzed commit d14fb94f and detected 0 issues on this pull request.
View more on Code Climate.
Merging #677 into master will increase coverage by
0.76%
. The diff coverage is91.30%
.
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 24.87% 25.63% +0.76%
==========================================
Files 128 128
Lines 2762 2762
Branches 393 393
==========================================
+ Hits 687 708 +21
+ Misses 2075 2054 -21
Impacted Files | Coverage Δ | |
---|---|---|
.../components/Main/Results/DeterministicLinePlot.tsx | 0.00% <0.00%> (ø) |
|
src/components/Main/Results/Utils.ts | 96.66% <95.45%> (-3.34%) |
:arrow_down: |
Related issues and PRs
Related to this Fixme, an incremental refactoring of the DeterministicLinePlot component.
(Additional context: #636, #671)
Description
Reduce the code complexity of
DeterministicLinePlot.tsx
by extracting thecomputeNewEmpiricalCases()
methods into a utility module. Also adds units tests for the method to aid future refactoring.Impacted Areas in the application
Slight reorganization of the code. Adds more unit tests.
Testing
Adds units tests for
computenewEmpiricalCases
in theUtils.ts
module.Run
yarn test
to test.