Closed abrie closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/czys6rzds ✅ Preview: https://covid19-scenarios-git-fork-abrie-refactor-deterministiclineplot.covid19-scenarios.now.sh
Merging #684 into master will increase coverage by
0.08%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 25.63% 25.71% +0.08%
==========================================
Files 128 128
Lines 2762 2753 -9
Branches 393 388 -5
==========================================
Hits 708 708
+ Misses 2054 2045 -9
Impacted Files | Coverage Δ | |
---|---|---|
.../components/Main/Results/DeterministicLinePlot.tsx | 0.00% <0.00%> (ø) |
Code Climate has analyzed commit c64cfde3 and detected 0 issues on this pull request.
View more on Code Climate.
Related issues and PRs
Related to this Fixme, an incremental refactoring of the DeterministicLinePlot component.
(Additional context: #636, #671, #677)
Description
Reduce the code complexity of
DeterministicLinePlot.tsx
by using computed property names to associate caseCounts with plotted data. This refactoring reduces the number of conditional statements and improves communication of intention.Impacted Areas in the application
Functionality unchanged, but the code
DeterministicLinePlot.tsx
is slightly changed.Testing
No unit tests were added by this change.