neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

Model cleaning #726

Closed vdruelle closed 4 years ago

vdruelle commented 4 years ago

Related issues and PRs

Description

Cleaning of the model.py code as it accumulated a lot of quick and dirty fixes which made it hard to use.

Impacted Areas in the application

The model.py and scenario.py files, and the generated scenarios.json. It did not change the model whatsoever, it is just a reformulation of the code.

Testing

I ran the code and re-generated the scenarios.json. Everything seems to work just fine.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/98gykmftc ✅ Preview: https://covid19-scenarios-git-modelcleaning.covid19-scenarios.now.sh

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 2d734f70 and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 4 years ago

Codecov Report

Merging #726 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   24.53%   24.53%           
=======================================
  Files         135      135           
  Lines        2902     2902           
  Branches      388      388           
=======================================
  Hits          712      712           
  Misses       2190     2190