Closed rneher closed 4 years ago
vercel[bot]
commented
4 years ago This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
π Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/q0bj4r59r β Preview: https://covid19-scenarios-git-refactor-plotdataprep.covid19-scenarios.now.sh
codecov[bot]
commented
4 years ago Merging #727 into master will decrease coverage by
9.59%. The diff coverage is7.91%.
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 24.53% 14.94% -9.60%
==========================================
Files 135 160 +25
Lines 2902 3105 +203
Branches 388 352 -36
==========================================
- Hits 712 464 -248
- Misses 2190 2641 +451 | Impacted Files | Coverage Ξ | |
|---|---|---|
| src/algorithms/preparePlotData.ts | 0.00% <0.00%> (ΓΈ) |
|
| src/algorithms/run.ts | 0.00% <0.00%> (ΓΈ) |
|
| src/algorithms/types/Param.types.ts | 100.00% <ΓΈ> (ΓΈ) |
|
| src/algorithms/utils/exportResult.ts | 0.00% <0.00%> (ΓΈ) |
|
| src/components/Faq/FaqTableOfContents.tsx | 0.00% <0.00%> (ΓΈ) |
|
| src/components/Layout/Footer.tsx | 0.00% <0.00%> (ΓΈ) |
|
| src/components/Layout/LanguageSwitcher.tsx | 0.00% <0.00%> (-47.62%) |
:arrow_down: |
| src/components/Layout/Layout.tsx | 0.00% <0.00%> (ΓΈ) |
|
| src/components/Layout/NavigationBar.tsx | 0.00% <0.00%> (ΓΈ) |
|
| src/components/Layout/NavigationLink.tsx | 0.00% <0.00%> (ΓΈ) |
|
| ... and 129 more |
codeclimate[bot]
commented
4 years ago Code Climate has analyzed commit b3058dfc and detected 0 issues on this pull request.
View more on Code Climate.
Description
move plot data preparation into the run function to avoid redoing this on rerender. also simplifies the plot component.
Impacted Areas in the application
plots and run.ts