neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

ensure mitigation intervals are correctly sampled in production #729

Closed rneher closed 4 years ago

rneher commented 4 years ago

Related issues and PRs

production version uses only one sample from the mitigation intervals which seems related to oddities of [...Array(numberStochasticRuns).keys()] in the production environment.

Description

Array(numberStochasticRuns).fill(1) returns a mappable array that does the trick

Testing

check whether uncertainty is properly handled for mitigations

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/jj2kzqt1m ✅ Preview: https://covid19-scenarios-git-hotfix-1410-stochasticintervals.covid19-scenarios.now.sh

codecov[bot] commented 4 years ago

Codecov Report

Merging #729 into staging will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           staging     #729   +/-   ##
========================================
  Coverage    24.68%   24.68%           
========================================
  Files          134      134           
  Lines         2884     2884           
  Branches       385      385           
========================================
  Hits           712      712           
  Misses        2172     2172           
Impacted Files Coverage Δ
src/algorithms/mitigation.ts 70.90% <0.00%> (ø)