neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

fix: disable loose transformations and shipped proposals in babel #730

Closed ivan-aksamentov closed 4 years ago

ivan-aksamentov commented 4 years ago

Related issues and PRs

Related to the issue resolved in https://github.com/neherlab/covid19_scenarios/pull/729.

729 solves the problem for this particular piece of code, while this PR aims to resolve the root cause globally.

Description

This disables loose transformations in babel, to avoid inconsistencies between different environments.

In particular, this code is transpiled differently in dev and prod when loose is enabled:

[...Array(numberStochasticRuns).keys()]

Additionally, this disables "shipped proposals", just in case, as it is a risky option too.

See also:

Impacted Areas in the application

Build, transpilation.

Testing

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/28zqunfdh ✅ Preview: https://covid19-scenarios-git-fix-babel-disable-loose-transformations.covid19-scenarios.now.sh

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 9d1f458d and detected 0 issues on this pull request.

View more on Code Climate.