search

neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

Hospital to Death Flow with Palliative Age-Specific Parameter #751

Closed tiagoandresvaz closed 4 years ago

tiagoandresvaz commented 4 years ago

Related issues and PRs

https://github.com/neherlab/covid19_scenarios/discussions/703

Description

To implement the new proposed flux in the model and interfaces according to the discussion above.

Impacted Areas in the application

Age-Specific Parameters, and Model.

Testing

Edit age-specific parameters to see changes in deaths modeled in results.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/neherlab/covid19-scenarios/eop6746jh ✅ Preview: https://covid19-scenarios-git-fork-tiagoandresvaz-master.neherlab.vercel.app

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 70facd95 and detected 0 issues on this pull request.

View more on Code Climate.

rneher commented 4 years ago

Thanks. I'll have a look at this tomorrow. it is a little hard to go through this PR as there are so many changes to data files which cause merge conflicts anyway. Could you isolate the changes to the model into a PR? And we can add scenarios somewhere else?

tiagoandresvaz commented 4 years ago

Yes! I will try to isolate it better and comment on changes to the model. It’s my first time doing a PR in the project , if something can be improved, I will be glad to do it !

Em ter, 7 de jul de 2020 às 16:03, Richard Neher notifications@github.com escreveu:

Thanks. I'll have a look at this tomorrow. it is a little hard to go through this PR as there are so many changes to data files which cause merge conflicts anyway. Could you isolate the changes to the model into a PR? And we can add scenarios somewhere else?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/neherlab/covid19_scenarios/pull/751#issuecomment-655061786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFXWDJ3CKW5K3YMQW2OMT3R2NWRPANCNFSM4OPHEXYQ .

-- Obrigado, Tiago Vaz

tiagoandresvaz commented 4 years ago

I am closing this PR and make a new one isolating changes in the model