search

neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

Additional PDF Details #755

Closed nspringman closed 4 years ago

nspringman commented 4 years ago

Related issues and PRs

Description

Fixed some of the existing short descriptions as well as adding a few longer descriptions in the form of footnotes. Copied long descriptions from homepage help text as to not cause any translation issues. Are there other notes or descriptions that need to be added? And is the footnote style the direction you want to go, or would another format be better?

Impacted Areas in the application

PrintPreview.tsx

Testing

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/neherlab/covid19-scenarios/ccmmkzijz ✅ Preview: https://covid19-scenarios-git-fork-nspringman-master.neherlab.vercel.app

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 8698a384 and detected 0 issues on this pull request.

View more on Code Climate.

ivan-aksamentov commented 4 years ago

@nspringman Thanks! LGTM.

The idea of #488 was more like on a scientific side, to improve content of the document as a whole (layout, informativeness, readability). This is a job for a domain expert. Back then we only applied a few cosmetic fixes and kinda abandoned that issue.

Anyways, your cleanup is welcome.

I will let @rneher to double check and merge.

rneher commented 4 years ago

Looks great to me. I like the superscript explanations for the pdf/print version!

rneher commented 4 years ago

you had it labeled as draft, did you want to add more? If not, I'll merge it....

nspringman commented 4 years ago

If there are other parameters in that list you think should have a longer description, I can certainly go ahead and add those. We had just selected the few that seemed most likely to warrant another note. Otherwise, if all looks okay with you, good to merge!

ivan-aksamentov commented 4 years ago

@nspringman Done, thanks!