Make footer even prettier Issue #672

r-s-rai commented 4 years ago

Related issues and PRs

Fixes issue #672 Related to issues #660 and #669

Description

More aesthetic footer with links to version string as well as to services that power the application

Impacted Areas in the application

This primarily affects the footer.

Testing

Take a look and see for yourself if it looks good. You may need to add "react-tooltip" if the page will not load. We added it as a dependency in package.json but in case it doesn't add it automatically make sure to manually install it with npm.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/neherlab/covid19-scenarios/hixd2va9s ✅ Preview: https://covid19-scenarios-git-fork-437su20-c-r-n-footer.neherlab.vercel.app

ivan-aksamentov commented 4 years ago

@r-s-rai Thanks! That's a good start.

Could we:

[x] replace png images with svg where possible, for additional crispness
[x] use this Vercel image: https://raw.githubusercontent.com/neherlab/webclades/master/packages/web/src/assets/img/powered-by-vercel.svg
[x] use this Vercel URL (with analytics tag. It's a part of our deal with them): https://vercel.com/?utm_source=nextstrain
[x] use <LinkExternal/> component instead of plain <a/> tag (this component opens links in the new tab, to not loose the user's focus, plus has a couple of security-related attributes). This component can accept the same attributes as plain anchor tag.
[x] simply use title attribute for tooltips (and remove new dependencies)
[x] add alt attributes for accessibility text description
[x] remove package-lock.json (we use yarn and yarn.lock, not npm)
[x] merge upstream master (not local master) into your branch, so that GitHub shows a sensible diff. Resolve merge conflicts along the way.

?

Don't forget to run yarn eslint for static analysis! The result should be clean in order to production build to pass.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit ad4d5616 and detected 0 issues on this pull request.

View more on Code Climate.

ivan-aksamentov commented 4 years ago

@r-s-rai This is indeed very pretty. Great job! Thanks a ton! :tada:

neherlab / covid19_scenarios