search

neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

[Bug] Fix overlapping of y-axis text on mitigation chart #78

Closed keevcodes closed 4 years ago

keevcodes commented 4 years ago

Browser (include version): Chrome 80 Operative System: Mac OS Catalina

The current behavior

On mobile, the y-axis text on the mitigation chart overlaps to the point where the chart is unreadable.

Iphone X Chrome:

Screenshot 2020-03-21 at 12 56 01

The expected behavior

Text should be displayed to the user clearly

related:

71

keevcodes commented 4 years ago

I'd like to tackle this issue

keevcodes commented 4 years ago

@ivan-aksamentov I think I've got a solution for this issue, however when trying to push to the newly created branch 'issue/78' I get a remote: Permission to neherlab/covid19_scenarios.git denied to keevcodes.

petebacondarwin commented 4 years ago

@keevcodes did you fork the repository to your own account?

petebacondarwin commented 4 years ago

For example I have https://github.com/petebacondarwin/covid19_scenarios And I would add this to my local github as a remote via:

git remote add pete https://github.com/petebacondarwin/covid19_scenarios

Then instead of trying to push to the source repository you push to your own fork:

git push -u pete my-local-branch-name

(Hopefully this is not teaching you to suck eggs :-) )

keevcodes commented 4 years ago

@petebacondarwin I completly overlooked that fact.. truth be told I know better, chalking this up to a typical dev brain fart moment. Thanks for the reminder

nnoll commented 4 years ago

@petebacondarwin beat me to it. Please fork the repo and submit a pull request with your fix. Thanks for your help!