neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

I want to contribute for Spanish translation #781

Open johnfelipe opened 4 years ago

johnfelipe commented 4 years ago

Really I want contribute for a Spanish version of this awesome application

ivan-aksamentov commented 4 years ago

@johnfelipe Hello!

There are 2 ways of doing this:

  1. You could edit the object in the i18n resource JSON file directly by providing English keys and corresponding Spanish values:

    • Take the original English keys in src/i18n/resources/en/common.json
    • Look at the Spanish file: src/i18n/resources/es/common.json, and compare it to the English one
    • Add missing English keys one by one, along with the corresponding Spanish translation in values
    • Note that if a key is missing in a Spanish file, it's okay - the English string will be shown in the application as a fallback. However, if translation is incorrect or empty, it is better to remove it completely, otherwise this incorrect string will be shown in the application.
    • Optionally, you can remove the old keys that are present in the Spanish file, but not in English. It means that this key was used previously, but is no longer needed.
    • Make sure you are forking off the latest master branch
    • You could create a draft pull request and add the translations incrementally. Vercel bot will provide a link to a temporary deployment of your PR, so that you can see the changes in action.
  2. If you prefer a UI tool, you can instead use GitLocalize. It also has a decent automatic translator (similar to Google Translate in quality). In this case, please sign up there and send me your username, and I will send you an invite to our repo.

    Here is the direct link to the Spanish translation on GitLocalize: https://gitlocalize.com/repo/4360/es/src/i18n/resources/en/common.json

Thanks!

johnfelipe commented 4 years ago

johnfelipe that is my username in github and i will do it with second option

El jue., 6 ago. 2020 a las 10:21, Ivan Aksamentov (notifications@github.com) escribió:

@johnfelipe https://github.com/johnfelipe Hello!

There are 2 ways of doing this:

1.

You could edit the object in the i18n resource JSON file directly by providing English keys and corresponding Spanish values:

  • Take the original English keys in src/i18n/resources/en/common.json https://github.com/neherlab/covid19_scenarios/blob/master/src/i18n/resources/en/common.json

    • Look at the Spanish file: src/i18n/resources/en/common.json]( https://github.com/neherlab/covid19_scenarios/blob/master/src/i18n/resources/en/common.json), and compare it to the English one
    • Add missing English keys one by one, along with the corresponding Spanish translation in values
    • Note that if a key is missing in a Spanish file, it's okay - the English string will be shown in the application as a fallback. However, if translation is incorrect or empty, it is better to remove it completely, otherwise this incorrect string will be shown in the application.
    • Optionally, you can remove the old keys that are present in the Spanish file, but not in English. It means that this key was used previously, but is no longer needed.
    • Make sure you are forking off the latest master branch
    • You could create a draft pull request and add the translations incrementally. Vercel bot will provide a link to a temporary deployment of your PR, so that you can see the changes in action. 2.

    If you prefer a UI tool, you can instead use GitLocalize https://gitlocalize.com/repo/4360. It also has a decent automatic translator (similar to Google Translate in quality). In this case, please sign up there and send me your username, and I will send you an invite to our repo.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neherlab/covid19_scenarios/issues/781#issuecomment-669995470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADIWFAQGI3VR5Y2TH5MHNDR7LDBJANCNFSM4PWH2F7Q .

johnfelipe commented 4 years ago

[image: SNAG-0613.png] says 100% inside but outside Spanish 81%, where is that strings remains

El lun., 10 ago. 2020 a las 11:02, john felipe urrego mejia (< ingenierofelipeurrego@gmail.com>) escribió:

johnfelipe that is my username in github and i will do it with second option

El jue., 6 ago. 2020 a las 10:21, Ivan Aksamentov (< notifications@github.com>) escribió:

@johnfelipe https://github.com/johnfelipe Hello!

There are 2 ways of doing this:

1.

You could edit the object in the i18n resource JSON file directly by providing English keys and corresponding Spanish values:

  • Take the original English keys in src/i18n/resources/en/common.json https://github.com/neherlab/covid19_scenarios/blob/master/src/i18n/resources/en/common.json

    • Look at the Spanish file: src/i18n/resources/en/common.json]( https://github.com/neherlab/covid19_scenarios/blob/master/src/i18n/resources/en/common.json), and compare it to the English one
    • Add missing English keys one by one, along with the corresponding Spanish translation in values
    • Note that if a key is missing in a Spanish file, it's okay - the English string will be shown in the application as a fallback. However, if translation is incorrect or empty, it is better to remove it completely, otherwise this incorrect string will be shown in the application.
    • Optionally, you can remove the old keys that are present in the Spanish file, but not in English. It means that this key was used previously, but is no longer needed.
    • Make sure you are forking off the latest master branch
    • You could create a draft pull request and add the translations incrementally. Vercel bot will provide a link to a temporary deployment of your PR, so that you can see the changes in action. 2.

    If you prefer a UI tool, you can instead use GitLocalize https://gitlocalize.com/repo/4360. It also has a decent automatic translator (similar to Google Translate in quality). In this case, please sign up there and send me your username, and I will send you an invite to our repo.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neherlab/covid19_scenarios/issues/781#issuecomment-669995470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADIWFAQGI3VR5Y2TH5MHNDR7LDBJANCNFSM4PWH2F7Q .

ivan-aksamentov commented 4 years ago

@johnfelipe I added you to GitLocalize.

I cannot see your attached image. Please submit it by replying on GitHub (not via email).

In order to start translating use this direct link to the Spanish table: https://gitlocalize.com/repo/4360/es/src/i18n/resources/en/common.json

In the table you will see 4 columns. See English string in the 1st column and type in Spanish translations in the 4th column. Note that there are multiple (5) pages of this table. Scroll way down to see the pagination.

I don't know how Gitlocalize calculates the translation percentage. For now just ignore this number. The current translation is mostly automated (Google Translate), performed with the "Machine translate" button. There should be many mistakes there - both factual and grammatical. Please review every string carefully, even if translation is already present.

After you are done with a portion of the translation, you can submit a Review Request and then Pull Request (at the same time. We don't do any additional review there). After Pull request is submitted, you can navigate to the Pull request page and Vercel bot will post a link to the temporary deployment. Wait for the Vercel deployment to complete (green circle in Github checks at the bottom) and then you can navigate to this link to see how your translation will look like in the application.

Thanks a lot for your help!