search

neherlab / covid19_scenarios

Models of COVID-19 outbreak trajectories and hospital demand
https://covid19-scenarios.org
MIT License
1.36k stars 354 forks source link

Missing Patients in hospital (data) in the results #803

Closed tiagoandresvaz closed 3 years ago

tiagoandresvaz commented 4 years ago

🐛 Bug Report

We are missing the bold pink line with Patients in hospital (data) in the results. It seems that was accidentally removed since last update!

look at ChartCommons.ts (lines 30 and 141)

ObservedHospitalized: 'currentHospitalized',
..
DATA_POINTS.ObservedHospitalized

It is not assigned anywhere else.

How to reproduce

Steps to reproduce the issue:

  1. Open the application in a browser 2.Run custom scenario
  2. Missing bold pink line in results plot

😯 Current Behavior

🤔 Expected Behavior

💁 Possible Solution

🔦 Context

💻 Code Sample

🌍 Your Environment

Software Version(s)
Browser
Operating System

Related

-

ivan-aksamentov commented 4 years ago

Hi @tiagoandresvaz, thanks for the report! This is probably related to our latest "second wave" update. I'll investigate.

ivan-aksamentov commented 4 years ago

@tiagoandresvaz I cannot confirm the breakage at least not on the client side. For example, if you load "ITA-Lombardia" from the default scenarios, then it shows the "hospitalized" line as expected.

The case counts (including hospitalized) are available only for some regions, where data parsers fetch from sources which have this information. If there's no line on the plot, then it normally means that we simply don't have data for it.

Can you tell if a particular region had hospitalization numbers before but now they have disappeared? In all cases, git history of case-counts directory or of caseCounts.json should manifest the disappearance at some point.

Now, about custom scenarios:

Unfortunately the user experience with custom case counts and custom scenarios is not perfect. Scenarios JSON files (default or custom) don't contain any case counts information (including hospitalizations). But they refer to case counts data by its name. The .population.caseCountsName field in src/assets/data/scenarios.json matches one of the .name fields in src/assets/data/caseCounts.json.

A custom scenario JSON should then refer to either one of the default case counts from src/assets/data/caseCounts.json (the names usually match a country or a region), or to a custom one. Custom case counts file can be "uploaded" beforehand using "or import your own data" link under "Confirmed cases" field. In this case, the .name in this file should be the same as the .population.caseCountsName in your custom scenario.

Let me know if you suspect that there's still a bug, or if you have ideas on how we can improve the experience.

tiagoandresvaz commented 4 years ago

When entering the site for the first time with default USA scenario, pink bold line is not showing for me. When I load Brazil also. I will try other devices, maybe is something weird happening only to me. I have tested with Lombardia first wave and it is ok!

Em seg, 7 de set de 2020 às 17:50, Ivan Aksamentov notifications@github.com escreveu:

@tiagoandresvaz https://github.com/tiagoandresvaz I cannot confirm the breakage at least on the client side. For example, if you load "ITA-Lombardia" from the default scenarios, then it shows the "hospitalized" line as expected.

The case counts (including hospitalized) are available only for some regions, where data parsers https://github.com/neherlab/covid19_scenarios/tree/master/data/parsers fetch from sources which have this information.

Can you tell if a particular region had hospitalization numbers before but now they have disappeared?

Now, about custom scenarios:

Unfortunately the user experience with custom case counts and custom scenarios is not perfect. Scenarios JSON files (default or custom) don't contain any case counts information (including hospitalizations). But they refer to case counts data by its name. So, a custom scenario JSON should refer to either one of the default case counts (the names usually match a country or a region), or to a custom one. Custom case counts file can be "uploaded" beforehand using "or import your own data" link under "Confirmed cases" field.

Let me know if you suspect that there's still a bug, or if you have ideas on how we can improve the experience.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neherlab/covid19_scenarios/issues/803#issuecomment-688506912, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFXWDLSNPGJH3LP3MOMVWTSEVBQNANCNFSM4QTEVEMA .

-- Obrigado, Tiago Vaz

rneher commented 3 years ago

Hi @tiagoandresvaz I think this is a matter of whether those data are available. We don't have hospitalization data for most countries. Italy is exceptionally good at this...

tiagoandresvaz commented 3 years ago

Hello @rneher
As Italy, here in our region we keep tracking hospital records. As we are not facing any real problem to project scenarios for our state, I will close this bug report. Do you have any recommendations on how to decide when to bundle the first and the second wave in separate files?