Various improvements to runners

neherlab / covid19_scenarios_data

Data preprocessing scripts and preprocessed data storage for COVID-19 Scenarios project

https://github.com/neherlab/covid19_scenarios

Other

41 stars 34 forks source link

Various improvements to runners #22

Closed dannysepler closed 4 years ago

dannysepler commented 4 years ago

Had some fun with this.

1) Is multiprocessing necessary? Not really. Is it fun? Absolutely! 2) Figured your parse_all may want to always setup the folder structures by default?

mserranom commented 4 years ago

Shouldn't be merged with the errors in licenses
Opinion: adding concurrency is including unnecessary complexity in the codebase.

rneher commented 4 years ago

Thank you, @dannysepler! these are useful improvements. But @mserranom points are well taken and keeping the code base simple will help others when adding more sources.

dannysepler commented 4 years ago

yeah, probably overkill at the moment! i'll close this out and come up with something more useful next time 👍