neherlab / treetime

Maximum likelihood inference of time stamped phylogenies and ancestral reconstruction
MIT License
222 stars 55 forks source link

BUG: clock_filter_method='residuals' should be 'residual' #267

Closed zacmon closed 6 months ago

zacmon commented 6 months ago

Hi,

I'm running TreeTime 0.11.2. There should probably be a check in TreeTime.clock_filter that checks the value of method:

if method != 'residual' or method != 'local':
    raise ValueError

As it stands, the default value given to the clock_filter method is residuals which is incompatible with the clock_filter method.

Zach

rneher commented 6 months ago

thanks for raising this! I pushed a fix!

https://github.com/neherlab/treetime/commit/624653a29b9025d9d97d33d01cada3d4bbe616d2