3.1 bosses added - Githubissues

nehtik / epgp

Automatically exported from code.google.com/p/epgp

0 stars 0 forks source link

3.1 bosses added #409

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

I took the liberty to add (most) 3.1 boss ID's to the boss.lua file. These
values were taken from LibBossIDs. I have not tested my changes yet, so be
warned. I was not able to find an ID for Thorim. After this boss event is
completed a chest with loot will spawn, just like in The Four Horsemen
encounter. Maybe this will help to find a solution to the recording of that
encounter as well.

Original issue reported on code.google.com by Alain.Mi...@gmail.com on 23 Apr 2009 at 8:04

Attachments:

boss.lua

GoogleCodeExporter commented 8 years ago

By the way, changes were made on the 5.4.5 code.

Original comment by Alain.Mi...@gmail.com on 23 Apr 2009 at 8:07

GoogleCodeExporter commented 8 years ago

Original comment by evlogimenos on 23 Apr 2009 at 8:29

Changed state: Duplicate

GoogleCodeExporter commented 8 years ago

Sorry, I did not see you were already working on this issue. Just checked your
boss.lua, and I saw you were missing ID's from the Assembly of Iron and Algalon 
the
Observer. I managed to find these and can be find in my supplied boss.lua file.

Original comment by Alain.Mi...@gmail.com on 23 Apr 2009 at 8:51

GoogleCodeExporter commented 8 years ago

Adding those Ids won't work. Boss kill detection needs to be a bit more smart 
to understand a set of Ids. Right 
now you will get a popup for each mini-boss death which is not what you want :-)

Original comment by evlogimenos on 23 Apr 2009 at 10:04

GoogleCodeExporter commented 8 years ago

Oh sorry I checked the file. Does Assembly have its own ID like Illidari 
Council used to have?

Original comment by evlogimenos on 23 Apr 2009 at 10:09

GoogleCodeExporter commented 8 years ago

I already understood a boss encounter with several sub bosses would probably 
require
additional code for EPGP to handle it correctly, since I noticed the TODO on 
The Four
Horsemen. ;-) When I started looking for the boss ID's I didn't expect the 
Assembly
of Iron encouter itself had an ID. I just checked LibBossIDs and the Illidari 
Council
indeed has an ID for it's encounter as well. I have attached the lua file of
LibBossIDs for your convenience.
Don't forget to add the ID for Algalon the Observer as well.

Original comment by Alain.Mi...@gmail.com on 23 Apr 2009 at 11:28

GoogleCodeExporter commented 8 years ago

LibBossIDs is wrong: http://www.wowhead.com/?npc=32867. 32867 is supposedly the 
id for Assembly of Iron. 
Since Algalon is not in either wowdb or wowhead I will way until it is to add 
it to epgp.

Original comment by evlogimenos on 23 Apr 2009 at 12:06