nehtik / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

Boss fight disconnections caused by recurring EP cycle. #420

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Participate in a 25-man raid.
2. Trigger recurring EP rewards.
3. During a boss fight a tick of recurring EP will cause a UI 
disconnection.

What is the expected output? What do you see instead?

I wouldn't expect the mod to force a UI disconnection.

What version of the product are you using? What locale is your client (en,
ru, kr, ch, es, tw)? What other addons do you have installed and what
versions?

Using 5.4.8 with <en> localization
Other mods are:
 - AtlasLoot Enhanced v5.04.00a
 - RPGO's CharacterProfiler v3.0.1
 - Recount v3.1d (stable)

Paste the text surrounded by -EPGP- in Guild Information here:

If this is about http://epgpweb.appspot.com integration, what is the realm
and region of your guild?

<N/A>

Please provide any additional information below.

Might have to actually be in Ulduar; it's the only raid we run. Amount of 
EP used might matter, but I doubt it. We do 25 EP per 15 minutes. I'm 
pretty sure it's 100% repro, but it's hard to force an EP tick during a 
fight.

Original issue reported on code.google.com by kpa...@gmail.com on 14 May 2009 at 3:13

GoogleCodeExporter commented 8 years ago
Sorry, missed that one question:

-EPGP-
@DECAY_P:25
@EXTRAS_P:100
@MIN_EP:0
@BASE_GP:200
-EPGP-

Original comment by kpa...@gmail.com on 14 May 2009 at 3:18

GoogleCodeExporter commented 8 years ago
Sorry, one more note, because the following behavior seems suspicious:

I have noticed that whenever my EPGP window is open, at least 80% of the time 
my 
DECAY button is flickering. It swaps between a gray and the normal red texture 
rapidly. It seems like something is going on behind the scenes on an almost 
constant 
basis, and for whatever reason it's affecting the texture on that button.

Since I don't know anything about EPGP's algorithm I could be way off, but 
perhaps 
during a bossfight there is just too much going on with EPGP and all the raid 
frame / 
Recount / combat log data flying around.

Original comment by kpa...@gmail.com on 14 May 2009 at 3:25

GoogleCodeExporter commented 8 years ago
My EPGP Decay button doesn't flicker, ever. Are you the raid leader or an 
officer
giving out EPGP? Do you have more than one person running the EPGP at the same 
time?

Original comment by dingochavezz@gmail.com on 14 May 2009 at 7:32

GoogleCodeExporter commented 8 years ago
Type /epgp debug and make a screenshot to attach on this bug report please. Your
flickering seems like something is wrong.

Original comment by evlogimenos on 14 May 2009 at 9:20

GoogleCodeExporter commented 8 years ago
I'm always both the raid leader and the master looter. What do you mean by 
"more than 
one person running EPGP"? More than one person with the mod, or more than one 
person 
running a recurring EP cycle?

@evlgimenos
Next raid I will get you the info.

Original comment by kpa...@gmail.com on 15 May 2009 at 12:06

GoogleCodeExporter commented 8 years ago
I mean more than one person updating EPGP.

Original comment by evlogimenos on 15 May 2009 at 12:13

GoogleCodeExporter commented 8 years ago
I have the exact same issues.

1) My Decay button flickers on occasion.

2) EPGP recurring EP awards sometimes boot me from Ulduar. I honestly can't 
recall if
it's just boss fights or trash. I'll note it during our next Ulduar run. The
disconnect happens perhaps 1 in every 5 updates.

I am not the raid lead, but I am an assist and master looter. Nobody else 
manages
EPGP at all.

Original comment by xyth...@gmail.com on 15 May 2009 at 8:43

GoogleCodeExporter commented 8 years ago
Can you do /epgp debug and print screen the contents of the debug window when 
the
button flickers?

Original comment by evlogimenos on 15 May 2009 at 8:54

GoogleCodeExporter commented 8 years ago
Will do, but it probably won't happen until next Tue (5/19). Most of the time 
the
button flickers after I decay EPGP, but I have seen it happen without. I'll 
post asap
when I catch it.

Original comment by xyth...@gmail.com on 15 May 2009 at 8:58

GoogleCodeExporter commented 8 years ago
First, the Decay button flickered when I did Decay today but by the time I hit 
/epgp
debug the flickering stopped and nothing was in the output.

Second, I was disconnected 100% of the time tonight when recurring EP was 
released
during a boss. It is definitely a boss+EP issue.

Original comment by xyth...@gmail.com on 20 May 2009 at 5:10

GoogleCodeExporter commented 8 years ago
Can you open /epgp debug during a boss then?

Original comment by evlogimenos on 20 May 2009 at 7:17

GoogleCodeExporter commented 8 years ago
Okay, so I only got one disconnection last night in our raid, but it was 
definitely 
during a boss. The main problem with opening the debug window is that it clears 
when 
I d/c, so I can't go back and look at it, or screenshot it, or whatever. Unless 
I'm, 
just a noob at EPGP and don't know where it's stored...

The flickering of the Decay button happens a lot when I first open EPGP, I've 
noticed. I know for a fact I've seen it happen for no apparent reason when 
having the 
mod panel open either while doing loot or just looking at the data. I'll get a 
screenshot of the debug output when it flickers during tonight's raid.

Original comment by kpa...@gmail.com on 20 May 2009 at 1:14

GoogleCodeExporter commented 8 years ago
I was about to ask the same question as kpaulg. How can I store the epgp debug 
output
if I'm going to be immediately disconnected when the error occurs?

Original comment by xyth...@gmail.com on 20 May 2009 at 1:56

GoogleCodeExporter commented 8 years ago
Here's a screenshot from tonight's right. I opened the debug window and snapped 
the 
shot immediately after noticing the haywire flickering. I have another from 
later in 
the night when it happened again if you want to see it.

Original comment by kpa...@gmail.com on 21 May 2009 at 3:40

Attachments:

GoogleCodeExporter commented 8 years ago
Yes please can you attach that one as well? This one doesn't show anything 
abnormal.

Original comment by evlogimenos on 21 May 2009 at 10:40

GoogleCodeExporter commented 8 years ago
Err...okay so I just looked at it before attaching it, and it's the EXACT SAME 
OUTPUT. The rest of the screenshot is totally different, taken over an hour 
later, 
but the debug output is 100% identical. Feels like I did something wrong, but 
all I 
did was type '/epgp debug' and hit 'Print Screen'.

The flickering happened right after I used that "Fixing" Mass EP you see there 
in the 
shot.

Original comment by kpa...@gmail.com on 22 May 2009 at 1:06

Attachments:

GoogleCodeExporter commented 8 years ago
I know this isn't the most helpful diagnostic comment, but I did not have a 
single
EPGP related disconnect tonight when I downgraded to 5.4.7. I would have kept 
5.4.8
to test, but I couldn't afford to DC during progression bosses. :)

Some change between 5.4.7 and 5.4.8 definitely is the origination of the bug. 
Doesn't
really narrow down the field, just sort of confirms what is known.

Original comment by xyth...@gmail.com on 22 May 2009 at 4:18

GoogleCodeExporter commented 8 years ago
One thing i've noticed , looking at epgp debug, is when the decay button 
flickers,
its doing a roster update.

Original comment by kllrloop...@gmail.com on 27 May 2009 at 4:12

GoogleCodeExporter commented 8 years ago
Yes this is normal. I am guessing you have other addons that trigger excessive 
guild
roster updates by calling GuildRoster. Any chance you can try running EPGP with 
a
minimal set of addons required for raiding only and see if this is the case?

Even if we can verify this, this is not the solution. The solution would be to
rewrite the epgp backend to write back data asynchronously, but that is not 
trivial.

Original comment by evlogimenos on 28 May 2009 at 12:50

GoogleCodeExporter commented 8 years ago
Is this still happening in 5.4.9?

Original comment by evlogimenos on 6 Jun 2009 at 9:57

GoogleCodeExporter commented 8 years ago
I will check on Tuesday when we raid again.

Original comment by kpa...@gmail.com on 7 Jun 2009 at 4:46

GoogleCodeExporter commented 8 years ago
I did not disconnect once. It looks like the latest version has fixed it. 
However, I 
feel compelled to add that even though I never disconnected, almost every time 
the 
recurring EP ticked, my game took a noticeable slowdown or temporarily froze 
altogether. That used to happen but I would d/c, so now I don't d/c but the 
hiccup 
still occurs. It really feels like the mod is not limiting its actions to those 
in 
the raid, but is instead still running through the entire guild list. I don't 
have 
any real proof of that, but I just can't see how a mere 25 iterations could 
have any 
direct effect on my game.

I don't know how your code works, but I'm wondering if the "show everyone" 
checkbox 
is not working 100% properly? I oftentimes check the box at the beginning of a 
raid 
in order to apply tardiness or no-show EP penalties to people who aren't in the 
raid 
[because they didn't show], and so maybe unchecking the box is not returning it 
to 
the raid-only state properly? I don't know, just a theory, and I'll run a test 
case 
tonight.

Original comment by kpa...@gmail.com on 10 Jun 2009 at 6:23

GoogleCodeExporter commented 8 years ago
I too upgraded to v5.4.10 and did not have a single disconnect.

Original comment by xyth...@gmail.com on 10 Jun 2009 at 6:32

GoogleCodeExporter commented 8 years ago
So I was using v5.4.9 on Tuesday when it didn't kick me, then I used v5.4.10 
tonight 
and it worked fine except for once, when I got the boot. However, that one time 
was on 
Auriaya and there was a whole mess of stuff going on. The recurring ticked many 
times 
during bossfights all night without any disconnects, so it seems as though it 
only 
boots me in extreme circumstances.

As for the test case with the "show everything" button, I found nothing 
conclusive. If 
I can figure anything else out I can submit a separate bug.

Original comment by kpa...@gmail.com on 11 Jun 2009 at 3:31

GoogleCodeExporter commented 8 years ago
kpaulg: When your game pauses do you have the epgp window open? Also how many 
members do you have in 
your guild?

Original comment by evlogimenos on 11 Jun 2009 at 6:08

GoogleCodeExporter commented 8 years ago
No, the EPGP window is never open because it's always in a boss fight and I'm 
doing my 
DPS thing. We have 372 guild members.

Original comment by kpa...@gmail.com on 12 Jun 2009 at 1:23

GoogleCodeExporter commented 8 years ago
Can you give a screenshot of the debug window when this happens? I want to see 
in 
particular how much time it takes for each LibGuildStorage OnUpdate call. It 
should be 
pretty obvious when you open the debug window (/epgp debug). You can scroll up 
and 
down to find the relevant debug lines.

Thanks for your patience in resolving the issue!

Original comment by evlogimenos on 12 Jun 2009 at 10:26

GoogleCodeExporter commented 8 years ago
I can try. Again, our next raid is Tuesday.

Original comment by kpa...@gmail.com on 15 Jun 2009 at 2:47

GoogleCodeExporter commented 8 years ago
Unfortunately I've had no luck in getting any debug for you. I'll keep trying, 
though.

I should note that I have disconnected several times now, especially this week. 
It's 
gotta be related to how much is going on at once. I'm only disconnecting, now, 
when a 
whole lot is happening on the screen. I don't d/c at all on fights like 
Razorscale, 
but Auriaya is almost 100% guaranteed. It just seems like the mod taxes the UI 
system 
quite a bit when it applies a recurring tick, and when too much stuff is going 
on the 
game kicks you out like a UI syncing issue, the same way AtlasLoot kicks you 
out when 
you try to query the server too much or when the item isn't stable.

Any possible way to delay the recurring ticks while in combat, and simply keep 
track 
of the time, then apply all the ticks after you're out of combat? Just a 
thought.

Original comment by kpa...@gmail.com on 18 Jun 2009 at 11:25

GoogleCodeExporter commented 8 years ago
If you do not do recurring EP you do not get disconnects?

Original comment by evlogimenos on 19 Jun 2009 at 6:03

GoogleCodeExporter commented 8 years ago
Most definitely not. Before you put out v5.4.10, I had stopped using recurring 
altogether because it was getting too problematic for me to be disconnecting 
for half 
the fights. I didn't have any disconnects at all for that week.

Original comment by kpa...@gmail.com on 21 Jun 2009 at 10:12