nehtik / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

EPGPLootmaster - Assigning loot but not assigning GP when target out of range #427

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Tonight we had two instances where I assigned loot using Master Looter / 
EPGP Lootmaster... The loot was correctly assigned, however the target had 
run off into the distance and the blizzard UI did not report (to me) that 
the loot was received.

As a result the character never got charged any GP for the item they 
received, also the EPGP Lootmaster window did not close and I had to click 
the "Discard Loot" button to close it.

The first time was on Emalon where the receiver of the loot had moved to 
by Archavon.  The second was after getting Razorscale down with the 
receiver of the loot being in the Antechamber.

-----

What steps will reproduce the problem?
1. Kill a boss, Master Looter
2. Click on an item, starting EPGP Lootmaster
3. Have the person who will get the loot go a long way away
4. Assign the loot to the person

What is the expected output? What do you see instead?

I would have expected the GP to be assigned when the loot was correctly 
assigned.  Since I never got notification of the loot being awarded in my 
chat log, I'm not sure how you'd catch the item being assigned, but it 
would be nice to have some popup asking if the GP should be assigned.

What version of the product are you using? What locale is your client (en,
ru, kr, ch, es, tw)? What other addons do you have installed and what
versions?
en

Paste the text surrounded by -EPGP- in Guild Information here:
N/A

Please provide any additional information below.

Original issue reported on code.google.com by mja1...@gmail.com on 27 May 2009 at 11:14

GoogleCodeExporter commented 8 years ago

Original comment by evlogimenos on 6 Jun 2009 at 10:13

GoogleCodeExporter commented 8 years ago
This is a limitation of the combat log. This can be solved by addons watching 
the log 
and publishing loots to the guild channel but then it is open for tinkering. I 
don't think 
this should be fixed: too complicated/error prone to fix when the easy fix is 
to stay 
close while looting.

Original comment by evlogimenos on 6 Jun 2009 at 10:34

GoogleCodeExporter commented 8 years ago
This happens to me all the time, so I would like to add that if you're like our 
guild 
and don't want to stand around while looting takes place, you can very easily 
assign 
the GP manually. With the mod open all of you have to do is select the member 
who 
received the masterlooted item and use the GP Reason dropdown. As long as you 
have 
hovered over the item in question [which obviously you would have if you were 
the ML], 
then it will appear in the dropdown list and then, boom, you've solved your GP 
problem.

Original comment by kpa...@gmail.com on 10 Jun 2009 at 6:28

GoogleCodeExporter commented 8 years ago
I don't see any other solution then making EPGP Lootmaster (core) to send 
information
about receiving the item to ML.
That guy getting the item will allways get the message and his EPGP Lootmaster 
(core
)addon can pass this information to EPGP Lootmaster (ML).

This requires raiders to have EPGP Lootmaster installed though.

Original comment by tomas.klapka on 16 Jun 2009 at 1:33

GoogleCodeExporter commented 8 years ago
True, this still doesn't fix any other addons like headcount etc. I do get 
events
when specific loot slots get cleared, so if i record who the ml tries to send 
the
item to and the lootslot that contained the item gets cleared i can safely 
assume who
got it and emulate the player X receives loot Y message locally. I still need to
figure out a way to prevent double messages. In any case, in still working hard 
to
find a solution ;)

Original comment by mackatack on 16 Jun 2009 at 3:31

GoogleCodeExporter commented 8 years ago
Tell your raiders to wait for one minute while you loot before moving on at 
'end of
section' bosses, or do as kpaulg and I do, assign the GP manually, I haven't 
broken
any fingers clicking my mouse buttons yet, or had a heart attack induced by the
stress of assigning GP manually.

Original comment by dingochavezz@gmail.com on 16 Jun 2009 at 3:56

GoogleCodeExporter commented 8 years ago
Ghehe indeed dingochavezz, but it's not that easy to see whether everything has 
gone
correctly, it would be much better if epgplootmaster were able to fix this 
annoying
little bug.

Original comment by mackatack on 17 Jun 2009 at 8:41

GoogleCodeExporter commented 8 years ago
I've proposed a patch in revision 1247 to alkis that fixed this problem by 
emulating
a loot message if the master looter doesn't properly receive one of these 
messages.
Only the master looter needs to have the patched EPGP installed to make this 
work. I
hope alkis will approve this patch soon, so all you guys can be ridden of this 
nasty bug.

Original comment by mackatack on 17 Jun 2009 at 12:52

GoogleCodeExporter commented 8 years ago

Original comment by mackatack on 17 Jun 2009 at 12:52

GoogleCodeExporter commented 8 years ago
Implemented in epgp-5.4.11, enjoy guys!

Original comment by mackatack on 19 Jun 2009 at 11:55

GoogleCodeExporter commented 8 years ago
Nice one! That will make a lot of people happy.

Original comment by dingochavezz@gmail.com on 19 Jun 2009 at 9:16

GoogleCodeExporter commented 8 years ago
Certainly hope so ;)

Original comment by mackatack on 20 Jun 2009 at 9:02