search

nehtik / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

Lag and occasional DC after recurring EP awards in combat #492

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1.  Be in combat, and allow an recurring award to go out.  This will cause
major momentary (2-3s) lag for the person awarding the EP, and occasionally
a disconnect.  I surmise this is the updating of the officer notes, because
if I have the epgp window open, I'll see the award button flash very very
quickly a bunch of times.

2.  The lag happens out of combat as well (ping will shoot up to 1000s of
ms), but it's much worse in combat (complete momentary freeze), and at
times results in a DC.

3.  If possible, I think an ideal solution would be to wait until I'm am
out of combat to make the award, and just then recalculate the next
recurring award time to account for the late award.

I'm at a location where I don't have ability to see what version I
currently am using, but I last updated on Sunday the 9th.  This problem has
been present in all versions I've used.

Original issue reported on code.google.com by bryce.mc...@gmail.com on 11 Aug 2009 at 7:28

GoogleCodeExporter commented 8 years ago 
This is most likely because of the log syncing. I will take a closer look.

Original comment by evlogimenos on 11 Aug 2009 at 9:09

GoogleCodeExporter commented 8 years ago

Original comment by evlogimenos on 11 Aug 2009 at 9:09

GoogleCodeExporter commented 8 years ago 
Tried it twice so far, I saw not disconnects from anyone. Is there something 
specific 
about your setup?

Original comment by evlogimenos on 13 Aug 2009 at 8:43

GoogleCodeExporter commented 8 years ago 
This happens to the person running our raids also.  Not always a DC but 
occasionally
he does in combat.  Would be nice to see a delay until combat ends.

Original comment by stevie.r...@gmail.com on 28 Aug 2009 at 1:33

GoogleCodeExporter commented 8 years ago 
This has happened to be before as well, but not in the past week or two. 
Interestingly, the DC hits both myself and another person who plays through 
internet
connection; perhaps the blizzard servers consider the updates spam and crosses 
some
threshold?

Original comment by chip.turner on 28 Aug 2009 at 1:36

GoogleCodeExporter commented 8 years ago 
This has been happening to us since we started using epgp when wrath came out.  
I
think it only happens to large guilds?  We have over 300 players.  I just give 
out
EPGP at set times now out of combat.

Original comment by gartre...@gmail.com on 21 Sep 2009 at 2:39

GoogleCodeExporter commented 8 years ago 
Can all the people that have problems report their guild size?

Original comment by evlogimenos on 21 Sep 2009 at 7:14

GoogleCodeExporter commented 8 years ago 
333 is our total size with 63 active "mains".

Original comment by gartre...@gmail.com on 21 Sep 2009 at 10:59

GoogleCodeExporter commented 8 years ago 
This stopped happening to me the other day when I was at a different location 
than I
normally raid from.  My server latency was higher (cross-country instead of 
just a
couple hundred miles) and my computer was weaker.  Perhaps there is some 
combination
of factors that contribute.

Guild size is maybe 40 raiders, with probably 30-33 in raid at the time.

Original comment by chip.turner on 21 Sep 2009 at 11:27

GoogleCodeExporter commented 8 years ago 
That should read, the problem stopped happening for me, but when I travelled, it
started again.  Once I returned home, it stopped and has been fine since.

Original comment by chip.turner on 21 Sep 2009 at 11:43

GoogleCodeExporter commented 8 years ago 
We have 221 players, 124 accounts.  Typical online for raid night is about 
45-55.

Original comment by bryce.mc...@gmail.com on 22 Sep 2009 at 5:13

GoogleCodeExporter commented 8 years ago 
Am also experiencing this issue.
It isn't as much of a problem out of combat, but in combat I get delays of 
roughly
3sec during recuring awards.

I'm running the latest version (5.5.7)

I agree with the OP (point 3), that a possible workaround could be to flag the
recuring award as 'pending' while in combat (and keep the timer going).
And award it say 10 seconds after combat ends. If some guilds set the recuring 
time
to say 15 minutes or less they may get 2 pending awards for very long fights.

You could put it as an option in the config.

Original comment by bob...@gmail.com on 5 Oct 2009 at 2:37

GoogleCodeExporter commented 8 years ago 
We are working on a (much) more efficient implementation of the epgp comm 
protocol 
which is going to fix this issue for good.

Original comment by evlogimenos on 5 Oct 2009 at 9:47

GoogleCodeExporter commented 8 years ago 
I put together a workaround patch inspired by bobm55's suggestion.  Diff 
attached if
anyone's interested.  It's not a perfect solution by any means, but works well 
enough
for me.

It adds an in-combat check to RecurringTicker so it won't fire the IncMassEPBy 
until
combat ends.  However it doesn't try to account for the time between 
vars.next_award
and the time at which combat actually ends, so that time is effectively 'lost'.

Original comment by nagol...@gmail.com on 8 Oct 2009 at 9:54

Attachments:

GoogleCodeExporter commented 8 years ago 
Could we please have this "patch" applied to the current version? I would 
better have
"lost" time than "lost tries" because I got lag in the middle of the combat.

Original comment by alexandr...@gmail.com on 24 Nov 2009 at 4:38

GoogleCodeExporter commented 8 years ago 
Evlo already said they are working on a better solution. In the mean time if 
you want
to use the patch provided by nagoleth, then feel free to do so.

Original comment by dingochavezz@gmail.com on 27 Nov 2009 at 1:23

GoogleCodeExporter commented 8 years ago 
I've applied the patch for the time being but wondering if there was an update 
to
this.  The lag burst isn't to much of a problem for a DPS that's awarding but a
healer or tank that's running the awards could cause the raid to wipe.

Original comment by black.ca...@gmail.com on 23 Feb 2010 at 4:43

GoogleCodeExporter commented 8 years ago 
Bump for update?

Original comment by black.ca...@gmail.com on 23 Jun 2010 at 8:25

GoogleCodeExporter commented 8 years ago 
There is a document on how to do this but right now improving the website is a 
priority. Is this happening for you still?

Original comment by evlogimenos on 26 Jul 2010 at 4:54

GoogleCodeExporter commented 8 years ago 
I applied the patch to 5.5.14 a while back and it seemed to work.  Using 5.5.17 
and it doesn't seem to help any.  I still get massive spikes while fighting a 
boss.  2-5 second ones.

Original comment by black.ca...@gmail.com on 27 Jul 2010 at 4:06

GoogleCodeExporter commented 8 years ago 
A extended version of the above patch (again 5.5.18) which allows for multiple 
updates to occur during combat (it counts them) and applies them at 10s 
intervals after the player leaves combat.

Original comment by tyrill.a...@gmail.com on 15 Oct 2010 at 3:39

Attachments:

GoogleCodeExporter commented 8 years ago 
This should be fixed in epgp-6. Master/Slave implementation avoids this mass 
sending of awards to the GUILD channel. Only a single message is sent by each 
award (mass or not).

First change: 
http://code.google.com/p/epgp/source/detail?r=108e818c3a7ea59dcad1e3e0da48965568
d325e6

Original comment by evlogimenos on 2 Dec 2010 at 1:33