neicnordic / sensitive-data-archive

https://neic-sda.readthedocs.io
GNU Affero General Public License v3.0
3 stars 7 forks source link

[download] Iss and jku matching should be done as URL matching #915

Closed aaperis closed 1 month ago

aaperis commented 3 months ago

Describe the bug Currently the matching is done via string matching:

if value.ISS == issuerValue && value.JKU == jkuValue

which causes problems if for example a trailing / is neglected somewhere.

Steps to reproduce

Remove or add a / in a iss or jku URL in the iss.json file of a local download instance and try again to access a dataset.

Expected behavior

Estimation of size: small

Estimation of priority: medium