Closed pospi closed 1 year ago
@nick-stebbings I made good progress with this today- CustomElements turned out to be a little complicated to fix, including changing the Shoelace lib being used. The components are now rendering but some look a little visually weird and I think I'd have to hand over to you in order to know what is left to clean up there. Hopefully just missing styles. Some other polish one of us may want to do in tying this off:
Great @pospi I will look over it and review tomorrow morning. I am working this weekend a bit, think you said you also were so we might be able to get it all tied up.
I posted re: the fonts stuff on discord but not sure you saw it. It can be imported from the styles package.
resolves #2
The storybook config seemed to be brittle. Never got it working even before I started refactoring. So have updated that toolchain.
Some things I'd like to clean up / fix (but please feel free if you'd like to take over)
ScopedElementRegistry
needs to be injected into Storybook somehow 'cos nothing rendersindividual component exports need to be tested (i.e.import
ing sub-paths)I'm not that familiar with https://www.typescriptlang.org/docs/handbook/project-references.html so have removed that to get things running. @nick-stebbings may want to restore it, as well as setting up some useful inheritance fortsconfig.json
withextends
so that the two configs under each package are no longer duplicated.Created additional issues for the crossed out items above. #5 , #6