neighbour-hoods / nh-launcher

Creating a group coherence with holochain apps
Other
4 stars 3 forks source link

198 named assessment tray configs (rebased) #206

Closed nick-stebbings closed 4 months ago

nick-stebbings commented 5 months ago

Zome code and testing for the four zome functions that now comprise the widgets crate:

set_default_assessment_tray_config_for_resource_def

get_default_assessment_tray_config_for_resource_def

set_assessment_tray_config

get_assessment_tray_config

@adaburrows perhaps we should combine this with 'de-widgetizing' the other type/file names? If so we need to decide what to swap out 'assessment_widget' with.

EDIT: this PR will now incorporate all renaming mentioned above and UI for this feature

nick-stebbings commented 5 months ago

@adaburrows

This is almost complete and I have incorporated the following:

Caveats for the tray config update functionality:

-We probably need to figure out how to validate that an updated tray config is actually different to the one being updated before submission. This is easy for the name, not so easy for the assessment control configs. Do you want this to rely on a deep equal? Or shall we just leave it for now?

nick-stebbings commented 5 months ago

Update: It is basically finished (for demo purposes) However there is STILL a couple of issues

This branch has the launcher in good shape to demo from the Feed applet first, probably. And with the odd hard reload if something goes wrong.

@adaburrows Update: As a follow up to our Discord call, both of the above issues are now sorted, because

You should be able to merge this now, once I resolve conflicts (I will do this now).

Update: all done, this will merge now.